Repository navigation
feat(AlertDialog): under a finger the alert appears and leaves the way iOS's does #8084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vjeux
wants to merge
33
commits into
meta:main
Choose a base branch
from
vjeux:uikit/c18-alerts-pr2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,614
−224
Draft
Changes from 26 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
62c9b4a
feat(AlertDialog): under a finger the alert appears the way iOS's does
vjeux dd1c162
Merge branch 'main' into uikit/c18-alerts-pr2
cixzhang c7f3449
Merge branch 'main' into uikit/c18-alerts-pr2
vjeux b86bb05
Merge main into the Toast branch (#8047 landed)
cixzhang c048c03
fix(Toast): a moved toast's card starts no transition
vjeux 9cbf06b
Merge #10223 (a moved toast's card starts no transition) into uikit/c…
vjeux d244534
Merge main into the Toast branch (#10223 landed)
cixzhang d0f8d96
test(AlertDialog): a toast the alert raises enters once across repeats
vjeux 773374e
docs(AlertDialog): split the file header's input list into sentences
vjeux d05b6c6
Merge main into the AlertDialog branch
vjeux f664bbc
fix(core): a leaving alert reads another window's nodes
vjeux 362ea7f
test(AlertDialog): a toast the alert raises stays painted as it closes
vjeux 91cb191
refactor(AlertDialog): keep the start scale's Effect note above it
vjeux d9bdee4
docs(AlertDialog): name the file header's inputs in one sentence
vjeux 008be81
Merge main into the AlertDialog branch
vjeux 057a36f
test(SnapPaging): the pager may bundle the input hold's host registry
vjeux 95c6e98
docs(AlertDialog): shorter file headers, an exact WebKit skip reason
vjeux 52802e3
fix(AlertDialog): close at the tap, fade an exit copy
vjeux fae82ea
Merge main into the AlertDialog branch
vjeux 3ec5192
chore(sandbox): AlertDialog cases on a page the document scrolls
vjeux b68d8bf
Merge main into the AlertDialog branch
vjeux 1589e5f
docs(AlertDialog): the touch exit still fades under reduced motion
vjeux bead618
Merge main into the AlertDialog branch
vjeux 31e5375
Merge main into the AlertDialog branch
vjeux 3e53941
Merge main into the AlertDialog branch
vjeux 77caa21
fix(Layer): a hold leaves a live region with nothing focusable live
vjeux 3393a18
docs(AlertDialog): the changeset says which announcements are read
vjeux 5ee2465
docs(AlertDialog): reword the start limit's comment as two sentences
vjeux 0e9f63a
Merge main into the AlertDialog branch
vjeux 643313e
docs(AlertDialog): the changeset no longer says a toast is read at once
vjeux e30bc88
fix(Layer): a swizzled copy's input hold sees the package's hosts
vjeux 0b033bc
Merge main
vjeux ec87860
refactor(Layer): the global modal hosts take a page-wide shared slot
vjeux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| '@astryxdesign/core': patch | ||
| --- | ||
|
|
||
| [feat] AlertDialog: under a finger the alert appears the way an iOS alert does. It scales down into place from 1.2 while it and the dimming fade in, on your theme's dialog entrance duration and curve. When it closes, it fades out with the dimming. With reduced motion it fades in without the scale, over 200 ms, and fades out within 200 ms. While it fades out, its content is inert: a touch, a click, a key or an assistive-technology activation on it does nothing, and focus leaves it until it returns to the opener. A toast stays operable above it, so one the action raises takes a tap and is read at once. On a phone, an alert with no `width` prop is now UIKit's 320 px wide in every theme, not 400 px. A `width` you pass still wins. With a mouse nothing changes. | ||
|
|
||
| An announcement made while the alert fades out under a finger, such as the words of a toast its action raises, is read: the page's live regions stay live through the fade. | ||
|
|
||
| @vjeux | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.