Declare modx property on modPackageBuilder for PHP 8.2 compatibility - #16989
Open
Ibochkarev wants to merge 1 commit into
Open
Declare modx property on modPackageBuilder for PHP 8.2 compatibility#16989Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Prevents "Creation of dynamic property ...::$modx is deprecated" when instantiating the package builder. Matches modTransportManager convention.
Mark-H
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
modPackageBuildersets$this->modxin the constructor but never declared the property. PHP 8.2+ emits:This PR adds
public $modx = null, same asmodTransportManager.How to test
Exit 0 on PHP 8.4 locally.
To see the original warning: create a
modPackageBuilderduring a package build (manager or_build). PHP 8.2+ logged the deprecation at line 70 before this change.Related issue(s)/PR(s)
Found in the manager error log.
Compatibility notes
PHP 8.2+ only. No runtime behavior change.
Breaking change assessment
No API changes. Safe for patch releases.
Test coverage
Replaced the placeholder
testExamplewithtestConstructorDoesNotCreateDynamicModxProperty. It checks for no dynamic-property deprecation on construction and confirms the$modxreference is set.Contributors
N/A
AI tool use
Cursor agent wrote the patch and test.