bug 2055645: support direct git tags in landoscript#1491
Open
bhearsum wants to merge 1 commit into
Open
Conversation
Landoscript supports requesting tags to be added to repositories. The [underlying tag action](https://github.com/mozilla-releng/scriptworker-scripts/blob/1cb7c72fcc9e5523c9c917fc8fa3a0ca620d4b2d/landoscript/src/landoscript/actions/tag.py) supports hg and git repositories, but git support is [only wired in when used by the merge day action](https://github.com/mozilla-releng/scriptworker-scripts/blob/1cb7c72fcc9e5523c9c917fc8fa3a0ca620d4b2d/landoscript/src/landoscript/actions/merge_day.py#L100)). The toplevel tag action support [hardcodes hg](https://github.com/mozilla-releng/scriptworker-scripts/blob/1cb7c72fcc9e5523c9c917fc8fa3a0ca620d4b2d/landoscript/src/landoscript/script.py#L93). In the immediate term, this means we can't make early-tagging and version-bump tasks work on Try (because there's no hg-to-git mapping we can look up there). In the medium term, this will be needed when we start firing release promotion from git events, and won't have an hg revision to feed to these tasks. I'm not _super_ happy with controlling hg vs. git based on the presence of hg_repo_url...but seeing as hg support as a finite lifespan, it's probably fine.
bhearsum
marked this pull request as ready for review
July 17, 2026 17:00
Contributor
Author
|
This was tested on Try for both version bump and early tagging tasks, which added the appropriate tags on this commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Landoscript supports requesting tags to be added to repositories. The underlying tag action supports hg and git repositories, but git support is only wired in when used by the merge day action). The toplevel tag action support hardcodes hg.
In the immediate term, this means we can't make early-tagging and version-bump tasks work on Try (because there's no hg-to-git mapping we can look up there). In the medium term, this will be needed when we start firing release promotion from git events, and won't have an hg revision to feed to these tasks.
I'm not super happy with controlling hg vs. git based on the presence of hg_repo_url...but seeing as hg support as a finite lifespan, it's probably fine.