Localized strings extracted to a separate, dedicated 'iRate' table. - #180
Open
kajot wants to merge 1 commit into
Open
Localized strings extracted to a separate, dedicated 'iRate' table.#180kajot wants to merge 1 commit into
kajot wants to merge 1 commit into
Conversation
Using a separate table avoids problems with corrupted Localized.strings files every other build (http://stackoverflow.com/questions/11481348/localizable-strings-failing-to-load-every-other-build). Problem occurs at least on Xcode 5.1.1, seems to be fixed in Xcode 6.
Author
|
I've prepared a demo of that issue: check out the test that passes/fails every other build: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a separate table avoids problems with corrupted Localized.strings files every other build (http://stackoverflow.com/questions/11481348/localizable-strings-failing-to-load-every-other-build). Problem occurs at least on Xcode 5.1.1, seems to be fixed in Xcode 6.
I'm not sure if it's 100% reproducible, seems to be a weird XCode quirk - it fails to merge two Localized.strings files (one from iRate, one from the host project), but only every OTHER build.
Creating a dedicated 'iRate' table, distinct from project-specific localization seems to be a good practice anyway, see: https://github.com/mattt/FormatterKit