Skip to content

Localized strings extracted to a separate, dedicated 'iRate' table. #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kajot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Localized strings extracted to a separate, dedicated 'iRate' table. #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...iRate.bundle/ar.lproj/Localizable.strings → iRate/iRate.bundle/ar.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/bn.lproj/Localizable.strings → iRate/iRate.bundle/bn.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/cs.lproj/Localizable.strings → iRate/iRate.bundle/cs.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/da.lproj/Localizable.strings → iRate/iRate.bundle/da.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...te.bundle/de-AT.lproj/Localizable.strings → iRate/iRate.bundle/de-AT.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/de.lproj/Localizable.strings → iRate/iRate.bundle/de.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/el.lproj/Localizable.strings → iRate/iRate.bundle/el.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/en.lproj/Localizable.strings → iRate/iRate.bundle/en.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/es.lproj/Localizable.strings → iRate/iRate.bundle/es.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/fa.lproj/Localizable.strings → iRate/iRate.bundle/fa.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/fr.lproj/Localizable.strings → iRate/iRate.bundle/fr.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/he.lproj/Localizable.strings → iRate/iRate.bundle/he.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/hi.lproj/Localizable.strings → iRate/iRate.bundle/hi.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/id.lproj/Localizable.strings → iRate/iRate.bundle/id.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/it.lproj/Localizable.strings → iRate/iRate.bundle/it.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/ja.lproj/Localizable.strings → iRate/iRate.bundle/ja.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/ko.lproj/Localizable.strings → iRate/iRate.bundle/ko.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/nl.lproj/Localizable.strings → iRate/iRate.bundle/nl.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/no.lproj/Localizable.strings → iRate/iRate.bundle/no.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/pa.lproj/Localizable.strings → iRate/iRate.bundle/pa.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/pl.lproj/Localizable.strings → iRate/iRate.bundle/pl.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/pt.lproj/Localizable.strings → iRate/iRate.bundle/pt.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/ru.lproj/Localizable.strings → iRate/iRate.bundle/ru.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/sk.lproj/Localizable.strings → iRate/iRate.bundle/sk.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/sl.lproj/Localizable.strings → iRate/iRate.bundle/sl.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/sv.lproj/Localizable.strings → iRate/iRate.bundle/sv.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/th.lproj/Localizable.strings → iRate/iRate.bundle/th.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/tr.lproj/Localizable.strings → iRate/iRate.bundle/tr.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/uk.lproj/Localizable.strings → iRate/iRate.bundle/uk.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...te.bundle/ur-IN.lproj/Localizable.strings → iRate/iRate.bundle/ur-IN.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...te.bundle/ur-PK.lproj/Localizable.strings → iRate/iRate.bundle/ur-PK.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/ur.lproj/Localizable.strings → iRate/iRate.bundle/ur.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ...iRate.bundle/vi.lproj/Localizable.strings → iRate/iRate.bundle/vi.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ....bundle/zh-Hans.lproj/Localizable.strings → .../iRate.bundle/zh-Hans.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
0 ....bundle/zh-Hant.lproj/Localizable.strings → .../iRate.bundle/zh-Hant.lproj/iRate.strings
View file
Open in desktop
File renamed without changes.
5 changes: 3 additions & 2 deletions iRate/iRate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,9 @@ - (NSString *)localizedStringForKey:(NSString *)key withDefault:(NSString *)defa
}
bundle = [NSBundle bundleWithPath:bundlePath] ?: [NSBundle mainBundle];
}
defaultString = [bundle localizedStringForKey:key value:defaultString table:nil];
return [[NSBundle mainBundle] localizedStringForKey:key value:defaultString table:nil];
NSString *localizedStringsTableName = @"iRate";
defaultString = [bundle localizedStringForKey:key value:defaultString table:localizedStringsTableName];
return [[NSBundle mainBundle] localizedStringForKey:key value:defaultString table:localizedStringsTableName];
}

- (iRate *)init
Expand Down