fix(vi): enter visual mode through command#1089
Draft
matystroia wants to merge 1 commit into
Draft
Conversation
Collaborator
|
One behavior shift worth knowing about is that the old Self::EnterViVisual => vec![
ReedlineOption::Event(ReedlineEvent::Esc),
ReedlineOption::Edit(EditCommand::SelectChar),
],Also a couple of test before merge?
Also the Afterwards I am fine with landing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Entering visual mode does not actually select char/grapheme under cursor. Thus you have to do something like
vlhto actually move selection to cursor. This happens because the parser eats thevinput and sets mode manually instead of it going through the usualCommand->EditCommandpipeline.Solution:
EditCommand::SelectCharthat sets selection anchor to current cursor positionCommand::EnterViVisualthat maps toEditCommand::SelectCharMode change still happens in parser, but now through the return value of
changes_mode.