unix: reject out-of-range chown ids but allow -1 for unchanged - #928
Open
avsm wants to merge 1 commit into
Open
Conversation
Collaborator
|
Won't the kernel check this for us anyway? Also, |
Contributor
Author
|
This is sufficiently weird that I thought a check here (in the portable layer) would be prudent The sign of uid_t/gid_t can be either signed or unsigned, so some casts here are probably necessary as well. e.g. python/cpython#46289 discusses this as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
posix allows -1 for 'unchanged'