Skip to content

unix: reject out-of-range chown ids but allow -1 for unchanged #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avsm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

unix: reject out-of-range chown ids but allow -1 for unchanged #928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib_eio/unix/eio_unix_stubs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,12 @@ CAMLprim value eio_unix_fchownat(value v_fd, value v_path, value v_uid, value v_
uid_t uid = Int64_val(v_uid);
gid_t gid = Int64_val(v_gid);
int ret;

if (uid < -1)
caml_unix_error(EINVAL, "fchownat uid", v_path);
if (gid < -1)
caml_unix_error(EINVAL, "fchownat gid", v_path);

caml_unix_check_path(v_path, "fchownat");
path = caml_stat_strdup(String_val(v_path));
caml_enter_blocking_section();
Expand Down
Loading