Skip to content

add missing dependencies to ocaml in dkml-install-runner packages - #24577

Merged
mseri merged 2 commits into
masterfrom
fix-dkml-install-runner-ocaml-dep
Oct 6, 2023
Merged

add missing dependencies to ocaml in dkml-install-runner packages#24577
mseri merged 2 commits into
masterfrom
fix-dkml-install-runner-ocaml-dep

Conversation

@raphael-proust

Copy link
Copy Markdown
Contributor

The lint job of PR #24542 shows the following errors:

2023-09-28 10:11.50: Error in dkml-install-runner.0.3.0:            warning 41: Some packages are mentioned in package scripts or features, but there is no dependency or depopt toward them: "ocaml"
2023-09-28 10:11.50: Error in dkml-install-runner.0.2.0:            warning 41: Some packages are mentioned in package scripts or features, but there is no dependency or depopt toward them: "ocaml"
2023-09-28 10:11.50: Error in dkml-install-runner.0.1.0:            warning 41: Some packages are mentioned in package scripts or features, but there is no dependency or depopt toward them: "ocaml"
2023-09-28 10:45.54: Job failed: 3 errors

This PR adds the OCaml dependencies. The version constraints are based on opam-health-check results

@mseri

mseri commented Oct 6, 2023

Copy link
Copy Markdown
Member

I wonder why this was not caught by the linter before

@mseri

mseri commented Oct 6, 2023

Copy link
Copy Markdown
Member

@jonahbeckford is this error in dkml-install-runner critical?

# File "runner/bin/validate_user.dlls.txt", line 1, characters 0-0:
# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/runner/bin/validate_user.dlls.txt _build/default/runner/bin/validate_user.dlls.txt.corrected
# diff --git a/_build/default/runner/bin/validate_user.dlls.txt b/_build/default/runner/bin/validate_user.dlls.txt.corrected
# index 7d36be4..75f8c9f 100644
# --- a/_build/default/runner/bin/validate_user.dlls.txt
# +++ b/_build/default/runner/bin/validate_user.dlls.txt.corrected
# @@ -1,3 +1,3 @@
#  Used DLLs:
# -	dllcamlstr
# -	dllunix
# +	dllunixbyt
# +	dllcamlstrbyt
# File "runner/bin/validate_admin.dlls.txt", line 1, characters 0-0:
# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/runner/bin/validate_admin.dlls.txt _build/default/runner/bin/validate_admin.dlls.txt.corrected
# diff --git a/_build/default/runner/bin/validate_admin.dlls.txt b/_build/default/runner/bin/validate_admin.dlls.txt.corrected
# index 7d36be4..75f8c9f 100644
# --- a/_build/default/runner/bin/validate_admin.dlls.txt
# +++ b/_build/default/runner/bin/validate_admin.dlls.txt.corrected
# @@ -1,3 +1,3 @@
#  Used DLLs:
# -	dllcamlstr
# -	dllunix
# +	dllunixbyt
# +	dllcamlstrbyt

Should we add an upper bound on ocaml 5.1?

@jonahbeckford

Copy link
Copy Markdown
Contributor

Yes. It should be less than 5.1. Later versions (0.4.0+) fix the issue.

Comment thread packages/dkml-install-runner/dkml-install-runner.0.1.0/opam Outdated
Comment thread packages/dkml-install-runner/dkml-install-runner.0.2.0/opam Outdated
Comment thread packages/dkml-install-runner/dkml-install-runner.0.3.0/opam Outdated
Comment thread packages/dkml-install-runner/dkml-install-runner.0.3.1/opam Outdated
@mseri

mseri commented Oct 6, 2023

Copy link
Copy Markdown
Member

I have reverted the commit from the mdx PR and updated this then. Thanks!

@mseri
mseri merged commit 044356b into master Oct 6, 2023
@mseri

mseri commented Oct 6, 2023

Copy link
Copy Markdown
Member

Lint successful

@mseri
mseri deleted the fix-dkml-install-runner-ocaml-dep branch October 6, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants