[Testing] Restore exact EVM updated-register count assertion - #8629
Open
janezpodhostnik wants to merge 1 commit into
Open
[Testing] Restore exact EVM updated-register count assertion#8629janezpodhostnik wants to merge 1 commit into
janezpodhostnik wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zhangchiqing
approved these changes
Jul 30, 2026
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8626, which relaxed
assert.Len(state.UpdatedRegisterIDs(), 13)toNotEmptyin the COAdryCalltests because the count varied between runs — losing theability to catch write-amplification regressions.
The variance is now fully characterized: the test env uses a random block ID, and
environment.uuidPartition(=sha256(blockID)[0]at txnIndex 0) selects the UUIDregister. Partition 0 (probability 1/256) reuses the legacy
uuidregister → 12 updatedregisters; all other partitions create a fresh
uuid_Nregister → 13. This 1-in-256 caseis what made the original exact assertion flaky.
This PR restores an exact assertion via a small helper that computes the expected count
(12 or 13) from the block ID, keeping the fixture's full randomness. Both branches
verified: 15 random-block runs and 3 runs with partition 0 forced, all with
-race.Test-only change; no production code touched.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.