Repository navigation
fix(cli): preserve repository protections in artifact exports - #1668
mldangelo-oai wants to merge 12 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Could we name this --sarif-output instead? --sarif results.sarif feels unintuitive and reads like an input flag, especially since scan import --json/--csv take input files. The existing export command uses --export-format sarif --output FILE, and the Python helper already uses --sarif-output. Making the output destination explicit would be clearer. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 660a222a5c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Keep the existing SARIF export workflow and preserve its repository protections when an output path uses a directory alias or
--source-rootpoints to a separate checkout.Related: #1571, #1572.
Changes
scan --output-dirandexportinterfaces. No new command, flag, or default.Testing
Risk and rollout
No scan-lifecycle or worker-setting changes. The runtime fixes preserve existing export protections. Automatic SARIF export can fail without failing the scan; explicit export reports errors and can be retried from saved results.
Public disclosure review