Repository navigation
build(deps): refresh compatible fixtures and repair telemetry audit - #295
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed September 22, 2026, 8:56 AM ET / 12:56 UTC (Revision 6). ClawSweeper reviewWhat this changesRefreshes plugin fixture packages and locks, repairs telemetry dependencies, adopts Inspector capture fixes, and updates diagnostic expectations, probe prerequisites, and hydration tooling. Merge readiness✅ Ready for maintainer review The refresh remains useful and is not implemented on main. Supplied runtime evidence supports the changes, prior entrypoint concerns are addressed, and no actionable patch defect was found. Priority: P2 Review scores
Verification
How this fits togetherCrabpot checks OpenClaw plugin compatibility using configured fixtures and a pinned Inspector. Package acquisition, registration capture, and isolated probes produce reports and CI policy results. flowchart TD
A[Plugin packages and locks] --> C[Pinned Inspector]
B[Fixture configuration] --> C
C --> D[Registration capture]
D --> E[Prerequisite checks and probes]
E --> F[Pass, failure, or coverage gap]
F --> G[Reports and CI policy]
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep dependency refreshes reproducible through fixture locks and upstream Inspector fixes, while preserving host ownership and explicit compatibility gaps. Do we have a high-confidence way to reproduce the issue? Not applicable to the dependency refresh as a whole; the capture repairs have specific before/after diagnostic and runtime evidence, which this read-only review did not rerun. Is this the best way to solve the issue? Yes: the branch uses existing fixture, prerequisite, and failure-classification mechanisms and adopts focused upstream fixes rather than adding parallel runtime logic. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 88ab1f2a9af0. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (5 earlier review cycles)
|
Refresh 25 fixture pins and compatible locks, update pnpm tooling, and regenerate current-track reports. Keep OpenClaw host ownership in the workspace plan and remove ineffective HAPI overrides while updating mutable Hono. Patch Jaeger within its stable major while retaining TencentDB 1.0.1 and SDK 0.218.0. The old SDK's configured propagation path passes a real synthetic trace round trip, and the unchanged lock-security gate is clear. Validated the full 19-step pinned-host suite in AWS, including 418 tests with 12 expected platform skips, strict fixture smoke, published Inspector smoke, zero breakages, and zero policy failures. Independent three-pass review is scoped-clean through P2. Related: #318, #302, #297.
e8e74d6 to
fefde8a
Compare
What Problem This Solves
Fixture fallback pins and committed dependency locks lag behind compatible stable packages. TencentDB's existing lock also retains a vulnerable Jaeger propagator that a normal compatible audit repair cannot update.
User Impact
Refresh 21 OpenClaw fixture pins to 2026.9.5, LightClawBot to 1.3.0, Weixin to 2.4.9, and Yuanbao to 2.18.3. Update compatible overrides, npm-generated locks, pnpm to 11.27.1, and pnpm/action-setup to 6.1.0. Preserve the promoted OpenClaw host, historical behavior targets, and external Git fixture pins. Builds on the exact reviewed runtime capture repairs in #350.
Discord's existing 2026.7.1 fallback manifest and lock remain byte-for-byte unchanged from main. Actual Discord 2026.9.5 needs atomic state-store observation/comparison methods absent from the pinned host and Inspector runtime. Its latest-track failure remains an explicit compatibility hold, and the incompatible standalone bump #347 is closed with evidence. A host promotion and matching Inspector runtime support should precede that update.
Dependency Boundaries
All changed locks use the repository's npm legacy-peer-deps procedure. Updated Weixin and LightClawBot locks exclude automatic OpenClaw peers. HAPI's explicit host dependency retains its published shrinkwrap: the full 309-entry graph is unchanged after removing six ineffective overrides. Its mutable Hono dependency advances to 4.13.8; a real npm ci passed.
TencentDB keeps the exact 1.0.1 artifact, registry URL, integrity, and SDK 0.218.0. A narrow stable-major Jaeger override selects 2.11.0. Normal audit repair retained Jaeger 2.7.1 and two high findings. The publisher-transition decision in #307 remains separate.
Observable Validation
The real SDK-configured propagator round trip after a clean install, with network exporters disabled, reports:
{"fixture":"1.0.1","sdkNode":"0.218.0","jaeger":"2.11.0","sdkConfiguredPropagator":"jaeger","traceRoundTrip":"pass","networkExporters":"none"}The unchanged security checker ran against the exact tracked npm files, matching CI's non-recursive checkout. External submodule lockfiles remain separately owned upstream inputs, not modified or exempted by this PR.
All eleven repaired isolated lanes were then exercised together: HAPI, TencentDB, Matrix, Voice Call, Brave, Codex, Google Meet, diagnostics-otel, Nostr, WhatsApp, and Feishu.
The blockers remain explicit coverage gaps; HAPI/TencentDB preserve their raw known failures and Matrix/Voice Call require named runtime prerequisites. Unknown failures still fail policy. #350 records source and freshly packed Inspector smoke proof (59 fixtures, zero breakages, computed tool value, preserved Gateway rejection).
Windows CI exposed CRLF conversion of two captured stderr fixtures. The same narrow LF attributes from #350 are included here; real Git autocrlf checkout replay and both focused tests passed on AWS. No production matcher normalization or startup-budget change was made. The existing #305 investigation remains untouched.
Reports were regenerated with explicit latest-track selection. A fresh checkout removed stale workspace-plan references to untracked upstream lockfiles; the resulting workspace JSON matches #350. Every implementation, integration, and metadata diff passed independent Codex review through P2. Final exact-head hosted CI must pass before landing.
Fixture Impact
Incorporates #318, #302, #297 and the compatible new Dependabot updates #328–#346, #348, and #349. Major consumer migrations remain separate; no external plugin source is rewritten.
Final Landing
Required Check run 35729654941 passed at
e1c07a604d2daa85ce3444dd07eef9c956676418: Linux, macOS, Windows, container, security, and all 26 isolated changed-fixture lanes. All three advisory canaries also passed. The complete final diff passed a two-part independent P2 review with no actionable findings.Merged normally as
61be4f5165d2ed2dcb65fc5821380ab57aaf86bc; the entire merged tree is identical to the tested head. #350 is superseded by this complete landing. Its failed standalone Windows evidence is preserved, and no startup/cleanup repair or #305 resolution is claimed. No release, tag, or project-version bump was performed.