Repository navigation
fix(ci): preserve Windows bootstrap failure diagnostics - #541
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR preserves bounded Windows bootstrap observations and helper terminal state on returned command errors. Example: The Windows helper fails while constructing its named pipe.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR repairs a verified diagnostic gap still present on main, with no actionable correctness findings; it remains draft with current-head required checks pending. Priority: P2 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe shared command supervisor runs checkout, audit, and inspector commands through a Worker and Windows PowerShell helper, returning captured output, command errors, and cleanup receipts to callers. flowchart LR
A[Checkout and inspector callers] --> B[Synchronous command owner]
B --> C[Worker supervisor]
C --> D[PowerShell helper]
D --> E[Owned target process]
D --> F[Bounded bootstrap observations]
F --> C
C --> B
Technical reviewBest possible solution: Land the bounded diagnostics through the existing supervisor while retaining the separate investigation into intermittent startup failures. Do we have a high-confidence way to reproduce the issue? Main constructs the pipe outside its error boundary and cannot report pre-serializer failures through its existing control channel; the intermittent startup trigger itself remains unknown. Is this the best way to solve the issue? The patch repairs the diagnostic producer and preserves its observations through the existing Worker and Error owners without changing execution policy. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 368a54f398e4. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. LabelsLabel changes: No label changes. Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReviewed October 19, 2026, 10:23 AM ET / 14:23 UTC (Revision 3). |
Follow-up: Windows profiler descendant-cleanup proofSix earlier Windows jobs (#538, #520, #522, #524, #532, #523) recorded hosted-runner communication loss during the static latest track; #538’s Windows job is one example. No cause or failed-test exception was established. The shared command supervisor’s Job scope has no observed upward runner-kill route. There is no configured three-hour cutoff. No timeout, heap, concurrency, or source change is justified as a runner-loss fix. Inspector at The follow-up oracle must exercise the actual runtime profiler: a leader leaves a descendant with retained or closed pipes; require extinction before the next sample or rescue, while an unrelated sentinel and parent survive. Preserve the original campaign order. This PR adds bootstrap diagnostics; it is not a proven runner-loss fix. Native current-head CI qualification remains pending. |
|
Native Windows component proof is now available for unchanged head The advisory job subsequently failed in static step4, |
|
@clawsweeper re-review Please review current head |
|
🦞👀 Re-review progress:
|
|
@clawsweeper re-review Please review exact head |
|
🦞👀 Re-review progress:
|
Preserve the owner-landed Windows diagnostics from #541 and both adjacent Unreleased entries. Independent Codex review of the combined candidate found no actionable P0-P2 defects.
Windows supervisor startup failures can lose the information needed to distinguish helper entry, pipe connection, and early preparation failure. The PowerShell error path currently depends on a pipe writer and serializer that may not exist yet, and callers that throw
result.errordiscard separately returned helper information. This change repairs that diagnostic boundary; the originalEOWNERSTARTstartup cause remains UNKNOWN.Related failures: Nostr #517 (Windows job) and Voice Call #518 (Windows job). These links provide context; this PR does not claim to fix either startup failure.
Change
ENOBUFSand preserves the first failure.No deadline, heap limit, phase allowlist, request-admission rule, target execution order, Windows Job ownership, or cleanup policy changes. No retries, execution fallback, dependency changes, or plugin-specific masking.
Production: +144 / -11, net +133 lines. This growth supplies previously unavailable bounded producer facts and preserves them across the existing ownership boundary; it does not add another execution path. Tests: +181 lines. Documentation/changelog: +19 lines.
Validation
endon both sides of completion, Worker serialization, and caller-throw preservation.git diff --checkpassed.fce7f1170c8fa5615f83913844da30c8ca519af9: the required Windows job and required Default Track aggregate passed. The recorded component evidence covers the four real-PowerShell early-failure cases, inherited output, framing, Worker transport, cancellation controls and retained resolver/contention checks. It does not establish the specific native resolver-expiry result. These results cover that historical head; the later5633edd6qualification is recorded below.Source: signed commit
fce7f1170c8fa5615f83913844da30c8ca519af9, based oncfe442dd122850bafbe11e1a4db3d2278a34694f; reviewed six-file diff SHA-256a47118bf9ee17d17cbd2c05f6bd0f07a98abb01a33ab52c8d86e786b62c28274.No release, deployment, package publication, or service change is requested or authorized.
Completed qualification of
5633edd6Signed merge
5633edd6f6a7aa8b58e1925243fd445d10423542integrated frozen mainde5d707b4a2cf864522c7689017c170bfc577fc1, preserving the accepted four runtime/test blobs and both sides of the README/changelog documentation. Its six-file PR diff was 31,266 bytes, SHA-2566349276c87ad31c75342c94cf585b788fc1cf508389005121f23ea2a2d12c2fc. Syntax checks, independent composition review and the one-pass P0-only canonical full-PR static review passed.The required Default Track aggregate passed on that exact head at 13:22:26 UTC. All four required OS/container lanes passed. The required native Windows job passed at 13:22:20 UTC.
Optional Windows rank-up move applied at
5633edd6: the completed Windows job directly confirms the four real-PowerShell early-failure cases (captured pipe construction, connection and preparation; inherited-output pipe construction), bounded framing and Worker-to-Error preservation, both cancellation controls, and retained checkout/resolver/contention assertions. It also passes “Windows preparation expiry releases only a nonadmitted checkout before the next resolver” (13,531 ms). This resolves the previously unclaimed resolver-expiry result for that head. These are component/owned-process assertions, not reproduction or attribution of the original intermittent startup failure.Current integration qualification
Signed merge
a875c69b490f4a0fba029d8c90a873f89e4273d7integrates frozen main368a54f398e4ebb07f86b29d34c623d5456d050cwith ordered parents[5633edd6f6a7aa8b58e1925243fd445d10423542, 368a54f398e4ebb07f86b29d34c623d5456d050c], tree140e082b566917be351167ce462be6b9de1675ee. The new main commit only updates the generated dashboard and reports. The merge is conflict-free; all 17 generated report blobs remain exactly main's, and all four runtime/test blobs remain exactly the accepted and passing5633edd6bytes. All main documentation and the diagnostic additions remain intact.31479df21dc4878aa2c38a43319afc32631237f83d7fe5b91a518a6ae164828f. Compared with the accepted prior PR patch, only the README blob-index metadata changes; the complete patch text and production/test/documentation allocation are unchanged.git diff --check, passed. Independent integration review accepted the signed ordered parents, exact source/doc composition and preserved main reports.a875c69b. Required Default Track run 39267880129 completed successfully; its strict aggregate 118220839773 passed at 18:05:05 UTC. All four required OS/container lanes passed, including native Windows 118112130250 at 18:04:59 UTC. Current ClawSweeper revision 3 covers this exact head with no findings, no before-merge item and no remaining Rank-up moves. The completed5633edd6CI remains historical supporting evidence.The three advisory host-corpus jobs at
5633edd6failed with V8 heap exhaustion attest/corpus/host.test.mjsagainst OpenClaw43e2d3ce2e9bafc5172b65a3d7c0b0a77fb78b6e. Those advisory failures and the original startup/runner-loss causes remain unresolved; this diagnostics PR does not claim to fix them. No timeout, heap, dependency or execution-policy change is included.Current-head advisory results remain separate: all three OS jobs in advisory run 39267880326 failed with explicit V8 heap-exhaustion messages against OpenClaw
e055783d9f99624b76edfc6d47e6b313a9b75ed3on Node 24.21.0. The current-head Windows advisory job directly passed the four real-PowerShell early-failure cases, bounded framing/tail and Worker-to-Error transport, both cancellation controls, and resolver expiry (13,534 ms) before that separate OOM. The precise allocation cause remains unknown; these failures do not establish a startup or runner-loss fix, and no heap/timeout adjustment is included.