Skip to content

ci(deps): bump golang.org/x/sys from 0.49.0 to 0.50.0 - #318

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/golang.org/x/sys-0.50.0
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/go_modules/golang.org/x/sys-0.50.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Bumps golang.org/x/sys from 0.49.0 to 0.50.0.

Commits
  • 00227f1 unix: avoid using stale written count from sendfile on freebsd/386 after EINVAL
  • aa1b965 unix: don't skip directory entries with zero inodes on Linux
  • 37845fb unix: reject a short SCM_CREDENTIALS payload in ParseUnixCredentials
  • 313c631 unix: add IoctlGetUint64
  • 4a36a34 cpu: add wasm32 "architecture"
  • 908ab59 windows: use SyscallN consistently for Windows system calls
  • f5cb030 unix: set R12 before the ppc64x syscall branch
  • 0e9e10f windows: remove MemoryBasicInformation.PartitionId field on windows/386
  • 9b24ac0 windows: fix PSAPI_WORKING_SET_EX_BLOCK bit accessors
  • 69a6691 windows/mkwinsyscall: read 32-bit results from the low half of the return reg...
  • See full diff in compare view

@dependabot
dependabot Bot requested a review from a team as a code owner November 15, 2026 20:12
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Nov 15, 2026
@clawsweeper

clawsweeper Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgolang.org/​x/​sys@​v0.49.0 ⏵ v0.50.084100100100100

View full report

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Nov 15, 2026
@clawsweeper

clawsweeper Bot commented Nov 15, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

This PR updates golang.org/x/sys from v0.49.0 to v0.50.0 and replaces its module checksums.

Example: Building Slacrawl from its pinned Go module dependencies.

  • Before: The build selects golang.org/x/sys v0.49.0.
  • After: The build selects golang.org/x/sys v0.50.0.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A minimal, useful dependency update supported by upstream inspection and passing head validation.
Proof confidence 🐚 platinum hermit (4/6) This Dependabot maintenance PR is outside the contributor proof gate; existing lock tests and successful head checks support compatibility without establishing live Slack behavior.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Slacrawl remains pinned to the preceding x/sys release and does not receive the newer upstream syscall corrections.
Reason: The update follows established dependency maintenance and keeps the existing module source, Go floor, and application interfaces.

Merge readiness

✅ Ready for maintainer review

Keep open: this is a focused dependency update that current main does not contain, with passing head checks and no actionable defect found.

Priority: P3
Reviewed head: 98083b2c12080b4fc2c22ae6e41e317a7688aab0

Before merge

None.

Findings

None.

Agent review details

How this fits together

Slacrawl uses x/sys for operating-system file locks that serialize media-cache operations; the dependency also supports transitive runtime consumers.

flowchart LR
  A[Media cache operations] --> B[Cache lock owner]
  B --> C[Unix Flock]
  B --> D[Windows LockFileEx]
  C --> E[Operating system]
  D --> E
Loading

Technical review

Best possible solution:

Land the existing version-and-checksum update through the repository's normal approval process.

Do we have a high-confidence way to reproduce the issue?

This PR does not report a Slacrawl bug requiring reproduction; its version change is directly verified in the pinned diff.

Is this the best way to solve the issue?

Updating the existing requirement and checksums is the smallest complete implementation, without introducing another owner or changing configuration.

AGENTS.md: not found in the target repository.

Codex review notes: model internal, reasoning medium; reviewed against 768fb0e9891b.

Provenance checked

  • x/sys module requirement and checksums keeps the original intent (1a0f2f7: The preceding merged update selected x/sys v0.49.0 while retaining the established dependency and compatibility gates.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

  • Exact introduced change: The pinned diff changes only the x/sys requirement and its two checksum entries; main still requires v0.49.0. (go.mod:16, 98083b2c1208)
  • Dependency contract applies: Production media locking directly imports x/sys/unix and x/sys/windows, establishing the dependency boundary inspected in this review. (internal/media/lock_unix.go:16, 768fb0e9891b)
  • Upstream compatibility and security inspection: The tagged comparison contains syscall fixes and additions; the inspected Windows lock wrappers retain their signatures and correctly narrow BOOL results to uint32. The module still requires Go 1.26.0, below Slacrawl's Go 1.27.0 floor, and the complete upstream tree contains no AGENTS.md. (windows/zsyscall_windows.go, 00227f1d1928)
  • Feature history and original intent: Media locking was added with the retention-purge feature; subsequent dependency maintenance includes the merged v0.49.0 update at build(deps): bump golang.org/x/sys from 0.48.0 to 0.49.0 #268. This PR preserves the existing locking owner and update pattern. (internal/media/lock_unix.go:16, 3bea752593c9)
  • Reviewed-head validation: Checks on the exact head report 16 successes and three skips, including successful dependency verification, Linux race tests, macOS tests, Docker, release snapshot, CodeQL, and Socket checks; no check failed. (.github/workflows/ci.yml, 98083b2c1208)
  • Discussion and canonical search: The full body, comments, reviews, and timeline establish no additional blocker; repository search finds earlier x/sys updates but no merged v0.50.0 replacement.

Likely related people:

  • Peter Steinberger: Raw commit 3bea752 adds internal/media/lock_unix.go:16 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 3bea752593c9; files: internal/media/lock_unix.go)
  • Vincent Koc: Raw commit 0a29749 adds go.mod:12 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: medium; commits: 0a297493e2f7; files: go.mod)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Labels

Label changes:

  • add P3: Routine dependency maintenance with no demonstrated urgent Slacrawl failure or security incident.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: Routine dependency maintenance with no demonstrated urgent Slacrawl failure or security incident.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 15, 2026, 3:25 PM ET / 20:25 UTC.

@dependabot
dependabot Bot force-pushed the dependabot/go_modules/golang.org/x/sys-0.50.0 branch from 98083b2 to fe4da4f Compare November 20, 2026 11:45
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.49.0 to 0.50.0.
- [Commits](golang/sys@v0.49.0...v0.50.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-version: 0.50.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/go_modules/golang.org/x/sys-0.50.0 branch from fe4da4f to 15c517f Compare November 20, 2026 11:53
steipete added a commit that referenced this pull request Nov 21, 2026
Refresh Crawlkit, Slack SDK, SQLite/libc, terminal libraries and Go support modules within the two-day dependency cooldown. Consolidates Dependabot #318, #319 and #320; align the TruffleHog action and selected scanner at 3.99.9. Preserve the Go 1.27.0 minimum and correct the preferred-toolchain documentation.

Verified static gates, govulncheck, all 17 race-tested packages, synthetic CLI export smoke, and four-platform snapshot packaging on AWS Crabbox. Independent Codex P0–P2 review found no actionable issues. No real Slack data, production changes, release, tag, or project version bump.
@steipete

Copy link
Copy Markdown
Collaborator

Consolidated the x/sys 0.50.0 update into #336 with the other compatible dependency updates. The combined change passed the race suite, vulnerability scanning, synthetic CLI smoke, and snapshot packaging. Closing this duplicate dependency PR; thank you.

@steipete steipete closed this Nov 21, 2026
@dependabot @github

dependabot Bot commented on behalf of github Nov 21, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/go_modules/golang.org/x/sys-0.50.0 branch November 21, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci dependencies Pull requests that update a dependency file go Pull requests that update go code other P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants