Skip to content

build(deps): refresh runtime libraries and secret scanner - #336

Merged
steipete merged 1 commit into
mainfrom
deps/round21
Nov 21, 2026
Merged

steipete merged 1 commit into
mainfrom
deps/round21

Conversation

@steipete

Copy link
Copy Markdown
Collaborator

Refresh the runtime dependency set to Crawlkit 0.18.0, Slack SDK 0.36.0, SQLite 1.62.0/libc 1.80.1, and compatible terminal and Go support updates. Consolidates Dependabot #318 and #320. All selected versions satisfy the two-day cooldown; the Go 1.27.0 minimum and preferred Go 1.27.4 toolchain remain unchanged.

Update both the pinned TruffleHog action and its explicitly selected scanner to 3.99.9, consolidating #319. Updating the action alone leaves the scanner on the old release. Correct the stale preferred-toolchain note in SPEC.md.

Slack 0.36's breaking changes were checked against the call sites: the changed event types are unused and API responses decode into fresh values. No archive, credential, production, or scheduled-acquisition behavior is enabled by this update.

Validation: every GOWORK=off make check gate passed on AWS Crabbox with Go 1.27.4, Node 26.13.0 and checksum-verified GoReleaser 2.18.2, including vulnerability scanning, race tests, CLI synthetic smoke and credential-free cross-platform snapshots. Independent Codex P0–P2 review: scoped-clean. PR CI provides the macOS 27 gate. No real Slack data or credentials used. Race suite and static gates: run. Clean-commit smoke and snapshot: run. The initial smoke correctly refused dirty Git metadata; the remaining gates passed from a clean detached checkout of this commit.

Vincent's #326 is intentionally untouched; #299 and #306 remain design discussions. No release, version bump or tag.

@steipete
steipete requested a review from a team as a code owner November 21, 2026 02:14
@clawsweeper

clawsweeper Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T02:15:12.280761Z 6c53c1c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgithub.com/​openclaw/​crawlkit@​v0.17.5-0.20261113104631-5276b56d7422 ⏵ v0.18.073 +1100100100100
Updatedgithub.com/​slack-go/​slack@​v0.35.0 ⏵ v0.36.073 +1100100100100
Updatedgolang.org/​x/​text@​v0.43.0 ⏵ v0.44.077 +1100100100100
Updatedgolang.org/​x/​sys@​v0.49.0 ⏵ v0.50.084100100100100

View full report

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Nov 21, 2026
@clawsweeper

clawsweeper Bot commented Nov 21, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

Updates runtime dependencies, advances both TruffleHog pins to 3.99.9, and corrects the documented preferred Go toolchain.

Example: A pull request triggers secret scanning.

  • Before: The action and scanner use TruffleHog 3.99.8.
  • After: The action and scanner use TruffleHog 3.99.9.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused, correct maintenance patch supported by passing checks and existing archive compatibility coverage; direct remote traces were not inspected.
Proof confidence 🐚 platinum hermit (4/6) This maintainer-authored maintenance PR is outside the contributor proof gate; successful CI and inspected compatibility tests support it, while linked remote traces were inaccessible.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
Reason: The maintainer-authored direction consolidates dependency upkeep without adding options or enabling new application behavior.

Merge readiness

✅ Ready for maintainer review

Keep open: this maintainer-authored refresh is not on main, consolidates useful dependency updates, and has no actionable findings.

Priority: P3
Reviewed head: 6c53c1c053b092c6bd47f4d1bd6d35a30c3a84b2

Before merge

None.

Findings

None.

Agent review details

How this fits together

The Slack client decodes API responses into the local archive, Crawlkit supplies shared archive infrastructure, and TruffleHog scans repository changes in CI.

flowchart LR
  A[Slack API] --> B[Slack SDK]
  B --> C[Slacrawl ingestion]
  C --> D[Crawlkit and SQLite]
  D --> E[Local archive]
  F[Repository changes] --> G[TruffleHog scanner]
Loading

Technical review

Best possible solution:

Land the coordinated refresh and resolve the three overlapping Dependabot PRs afterward.

Do we have a high-confidence way to reproduce the issue?

No application bug is claimed; the old and new dependency selections are directly verifiable in the pinned diff.

Is this the best way to solve the issue?

The coordinated version updates are appropriately scoped and preserve the existing dependency and scanner owners.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 5b1fc3c06c01.

Provenance checked

  • Runtime dependency selection keeps the original intent (build(deps): refresh archive dependencies and Node tooling #310: Earlier coordinated refreshes kept the SQLite/libc runtime pair aligned while retaining the supported Go minimum.)
  • Crawlkit seed API dependency keeps the original intent (0a29749: Private Slack seed staging required the earlier Crawlkit pseudo-version; the selected published release retains those APIs.)
  • TruffleHog action and scanner pairing keeps the original intent (build(deps): pin patched TruffleHog scanner and refresh CodeQL #304: Pinning the action alone left its scanner runtime floating, so both selections were intentionally pinned.)
  • Preferred toolchain documentation keeps the original intent (f5612ae: The existing module already selects Go 1.27.4; updating SPEC.md removes a stale 1.27.2 reference.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

Likely related people:

  • Peter Steinberger: Raw commit 062af78 adds go.mod:8 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 062af7813443; files: go.mod)
  • Vincent Koc: Raw commit 905ac75 adds .github/workflows/secret-scan.yml:47 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 905ac75f8337; files: .github/workflows/secret-scan.yml)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Root-cause cluster

Relationship: canonical
Canonical: #336
Summary: This PR explicitly consolidates three narrower dependency updates, with overlap verified against the selected versions.

Members:

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Labels

Label changes:

  • add P3: This is a focused maintenance refresh with passing checks and no demonstrated urgent user-facing failure.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: This is a focused maintenance refresh with passing checks and no demonstrated urgent user-facing failure.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 20, 2026, 9:27 PM ET / November 21, 2026, 02:27 UTC.

@steipete
steipete merged commit e6f6127 into main Nov 21, 2026
26 of 27 checks passed
@steipete
steipete deleted the deps/round21 branch November 21, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build other P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants