Skip to content

ci(deps): bump trufflesecurity/trufflehog from 3.99.8 to 3.99.9 - #319

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/github_actions/trufflesecurity/trufflehog-3.99.9
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/github_actions/trufflesecurity/trufflehog-3.99.9

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Bumps trufflesecurity/trufflehog from 3.99.8 to 3.99.9.

Release notes

Sourced from trufflesecurity/trufflehog's releases.

v3.99.9

What's Changed

New Contributors

Full Changelog: trufflesecurity/trufflehog@v3.99.8...v3.99.9

Commits
  • 3bd2b58 Add SOURCE_TYPE_GENERIC source type (#5553)
  • 256d9d4 Report Datadog resources as unbounded instead of permission-less bindings (#5...
  • ef3c2c5 Fix GitHub GraphQL comment scan retries and paging (#5548)
  • f8ad753 Clean up Syslog source logging for per-source debug (#5538)
  • 0344195 Update module pault.ag/go/debian to v0.21.3 (#5546)
  • 2c07884 Update module golang.org/x/crypto to v0.59.0 [SECURITY] (#5544)
  • 1887667 feat(detectors): add Serval API key detector (#5528)
  • 221b979 Clean up Elasticsearch source logging for per-source debug (#5521)
  • 5dce9d4 Clean up Hugging Face source logging for per-source debug (#5523)
  • 47325ab Clean up CircleCI and Travis CI logging, share API log hooks (#5524)
  • Additional commits viewable in compare view

@dependabot
dependabot Bot requested a review from a team as a code owner November 15, 2026 20:12
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Nov 15, 2026
@clawsweeper

clawsweeper Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P2 Normal priority bug or improvement with limited blast radius. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels Nov 15, 2026
@clawsweeper

clawsweeper Bot commented Nov 15, 2026

Copy link
Copy Markdown

Codex review: needs changes before merge.

What this changes

This PR updates the TruffleHog GitHub Action reference from 3.99.8 to 3.99.9.

Example: The secret-scanning workflow runs on a pull request.

  • Before: The 3.99.8 action launches the 3.99.8 scanner image.
  • After: The 3.99.9 action still launches the 3.99.8 scanner image.

Review scores

Measure Result What it means
Overall readiness 🦪 silver shellfish (2/6) The existing CI validation is healthy, but the patch leaves the advertised scanner upgrade unapplied.
Proof confidence 🐚 platinum hermit (4/6) This bot-authored CI dependency update requires no shipped application demonstration; successful checks support workflow validity.
Patch quality 🦪 silver shellfish (2/6) 1 actionable review finding remain.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Partial
User problem: Repository contributors need secret scanning to run the dependency version being adopted.
Reason: Keeping the existing security scanner current is useful maintenance, and prior merged updates establish the intended alignment of action and runtime versions.

Merge readiness

⛔ Needs changes before merge - 1 item remains

Keep this PR open: the update is not on main, and its scanner runtime pin needs to advance alongside the action reference.

Priority: P2
Reviewed head: 883fdbcacf577d42a2bda064f76fe1a36f7a0cae

Before merge

  • Advance the scanner image version alongside the action pin (P2) - The updated action still receives version: "3.99.8" at line 63. Its composite implementation uses that input as the Docker image tag, and action.yml is unchanged between these releases, so push and pull-request scans continue executing 3.99.8 and receive none of the advertised 3.99.9 scanner fixes. Update the existing version input to 3.99.9, as the previous merged dependency update did.

Findings

  • [P2] Advance the scanner image version alongside the action pin — .github/workflows/secret-scan.yml:58
Agent review details

How this fits together

The secret-scanning workflow passes a Git commit range to TruffleHog and fails CI when verified credentials are found.

flowchart LR
  A[Push or pull request] --> B[Checkout repository]
  B --> C[Resolve commit range]
  C --> D[Pinned TruffleHog action]
  D --> E[Versioned scanner image]
  E --> F[Secret scanning result]
Loading

Technical review

Best possible solution:

Advance the existing version input to 3.99.9 while retaining the immutable action reference and current scanning settings.

Do we have a high-confidence way to reproduce the issue?

Source tracing establishes that every workflow invocation still selects the 3.99.8 scanner image because the upstream action passes inputs.version directly into the Docker image tag.

Is this the best way to solve the issue?

Updating both existing pins is the smallest complete dependency update and follows the reproducibility contract established by prior merged work.

Full review comments:

  • [P2] Advance the scanner image version alongside the action pin — .github/workflows/secret-scan.yml:58
    The updated action still receives version: "3.99.8" at line 63. Its composite implementation uses that input as the Docker image tag, and action.yml is unchanged between these releases, so push and pull-request scans continue executing 3.99.8 and receive none of the advertised 3.99.9 scanner fixes. Update the existing version input to 3.99.9, as the previous merged dependency update did.
    Confidence: 1

Overall correctness: patch is incorrect
Overall confidence: 0.99

AGENTS.md: not found in the target repository.

Codex review notes: model internal, reasoning medium; reviewed against 768fb0e9891b.

Provenance checked

Testing

Proof path: none.

Security

None.

Evidence

Acceptance criteria:

  • make workflow-lint
  • Inspect the repaired head's secret-scanning job output and confirm the Docker image tag is ghcr.io/trufflesecurity/trufflehog:3.99.9.

What I checked:

Likely related people:

  • Vincent Koc: Raw commit 905ac75 adds .github/workflows/secret-scan.yml:47 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 905ac75f8337; files: .github/workflows/secret-scan.yml)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Labels

Label changes:

  • add P2: The dependency update needs a focused runtime-pin correction; existing scanning continues to run.
  • add rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🐚 platinum hermit and patch quality is 🦪 silver shellfish.
  • add status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action.

Label justifications:

  • P2: The dependency update needs a focused runtime-pin correction; existing scanning continues to run.
  • rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🐚 platinum hermit and patch quality is 🦪 silver shellfish.
  • status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 15, 2026, 3:25 PM ET / 20:25 UTC.

Bumps [trufflesecurity/trufflehog](https://github.com/trufflesecurity/trufflehog) from 3.99.8 to 3.99.9.
- [Release notes](https://github.com/trufflesecurity/trufflehog/releases)
- [Commits](trufflesecurity/trufflehog@ea68ca0...3bd2b58)

---
updated-dependencies:
- dependency-name: trufflesecurity/trufflehog
  dependency-version: 3.99.9
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/github_actions/trufflesecurity/trufflehog-3.99.9 branch from 883fdbc to 8fe0b1b Compare November 16, 2026 05:11
steipete added a commit that referenced this pull request Nov 21, 2026
Refresh Crawlkit, Slack SDK, SQLite/libc, terminal libraries and Go support modules within the two-day dependency cooldown. Consolidates Dependabot #318, #319 and #320; align the TruffleHog action and selected scanner at 3.99.9. Preserve the Go 1.27.0 minimum and correct the preferred-toolchain documentation.

Verified static gates, govulncheck, all 17 race-tested packages, synthetic CLI export smoke, and four-platform snapshot packaging on AWS Crabbox. Independent Codex P0–P2 review found no actionable issues. No real Slack data, production changes, release, tag, or project version bump.
@steipete

Copy link
Copy Markdown
Collaborator

Consolidated into #336, updating both the TruffleHog action pin and its explicit scanner version to 3.99.9 so CI actually uses the refreshed scanner. Closing this duplicate dependency PR; thank you.

@steipete steipete closed this Nov 21, 2026
@dependabot @github

dependabot Bot commented on behalf of github Nov 21, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/github_actions/trufflesecurity/trufflehog-3.99.9 branch November 21, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code other P2 Normal priority bug or improvement with limited blast radius. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants