[release-4.22] SPLAT-2865: Add vSphere multi vCenter Day 2

[vr4manta]

SPLAT-2865

Changes

• Created new VSphereMultiVCenterDay2 feature gate
• Added logic to handle day 2 processing of adding / removing vCenters

Notes

This PR is attempting to backport the following PRs:

• SPLAT-2649: Added vSphere Day 2 logic to CRDs #2784
• Revert "TRT-2701: Revert "SPLAT-2793: Promoted VSphereMultiVCenterDay2 feature gate to TP"" #2886
• SPLAT-2827: Added vSphere failure domain to vcenter check #2932

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2865 which is a valid jira issue.

Details

In response to this:

SPLAT-2865

Changes

• Created new VSphereMultiVCenterDay2 feature gate
• Added logic to handle day 2 processing of adding / removing vCenters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1ff4f438-44b6-4914-b3d8-aac80569c2f5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[vr4manta]

/test all

[qodo-for-rh-openshift]

PR-Agent: could not find a component named all in a supported language in this PR.

[vr4manta]

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial openshift/library-go#2404 openshift/installer#10740 openshift/cluster-cloud-controller-manager-operator#498 openshift/cluster-config-operator#498 openshift/machine-api-operator#1531

[openshift-ci]

@vr4manta: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

[vr4manta]

/retest

[vr4manta]

/pipeline required

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

[vr4manta]

/assign @everettraven

[everettraven]

/label backport-risk-assessed
/label jira/valid-bug

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 42fb550 and 2 for PR HEAD 7aef34c in total

[vr4manta]

/retest

[vr4manta]

/retest

[vr4manta]

/retest

[everettraven]

Looks like some infrastructure related issues. Pretty unlikely that the addition of this TPNU feature gate is causing or will issues.

/override ci/prow/e2e-aws-ovn-hypershift

[openshift-ci]

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/e2e-aws-ovn-hypershift

Details

In response to this:

Looks like some infrastructure related issues. Pretty unlikely that the addition of this TPNU feature gate is causing or will issues.

/override ci/prow/e2e-aws-ovn-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[vr4manta]

/retest

[vr4manta]

Looks like something was merged that created a new file / feature gate. I'll need to regenerate to add that in.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[vr4manta]

/verified by @vr4manta vi CI

[openshift-ci-robot]

@vr4manta: This PR has been marked as verified by @vr4manta vi CI.

Details

In response to this:

/verified by @vr4manta vi CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vr4manta]

/tests e2e-vsphere-ovn

[openshift-ci]

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-hypershift-integration	4f1fc2a	link	true	/test verify-hypershift-integration
ci/prow/e2e-aws-ovn-hypershift	7aef34c	link	true	/test e2e-aws-ovn-hypershift
ci/prow/verify-crdify	ec9c1da	link	true	/test verify-crdify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.