[release-4.22] SPLAT-2865: Add vSphere cloud config modules from 3CMO

[vr4manta]

SPLAT-2865

Changes

• Migrated 3CMO vSphere cloud config modules to library-go
• Changed Node struct to not be a pointer in CPIConfig

Notes

This PR is backporting the following PRs in relation to the vSphere multi vCenter day 2 support feature:

• SPLAT-2651: Added vSphere cloud config modules from 3CMO #2175
• SPLAT-2651: Changed Node struct to not be pointer in CPIConfig #2195

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2865 which is a valid jira issue.

Details

In response to this:

SPLAT-2865

Changes

• Migrated 3CMO vSphere cloud config modules to library-go
• Changed Node struct to not be a pointer in CPIConfig

Notes

This PR is backporting the following PRs in relation to the vSphere multi vCenter day 2 support feature:

• SPLAT-2651: Added vSphere cloud config modules from 3CMO #2175
• SPLAT-2651: Changed Node struct to not be pointer in CPIConfig #2195

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 193dd6f6-c2bb-4016-a722-c70d1e0270f5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[vr4manta]

/retest

[openshift-ci]

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

@vr4manta: This PR was included in a payload test run from openshift/api#2969
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

[vr4manta]

/assign @elmiko

[openshift-ci]

@vr4manta: This PR was included in a payload test run from openshift/api#2969
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1d51e210-a858-11f1-8021-2ae6565127f3-0

[openshift-ci]

@vr4manta: This PR was included in a payload test run from openshift/api#2969
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb9027b0-a873-11f1-9d70-57471176ae00-0

[openshift-ci]

@vr4manta: This PR was included in a payload test run from openshift/api#2969
trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-1of2
• periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bb3dc9d0-ab78-11f1-89a9-861801216705-0

[openshift-ci]

@vr4manta: This PR was included in a payload test run from openshift/api#2969
trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-1of2
• periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1248eda0-ab87-11f1-8f62-cd05816d43e3-0

[bertinatto]

/assign @jsafrane

[openshift-ci]

@vr4manta: This PR was included in a payload test run from openshift/api#2969
trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-1of2
• periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-zones-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c30f5bc0-ab90-11f1-99a2-f02f9eef2847-0

[jsafrane]

/lgtm
/approve

I can see the cherry-picked commits are the same as in master and someone must have reviewed them there ;-)

[bertinatto]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bertinatto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment