NO-ISSUE: Extend timeout for waiting for `UpdatePrepared` MCN condition for SNO resiliency by isabella-janssen · Pull Request #6428 · openshift/machine-config-operator

isabella-janssen · 2026-08-20T18:54:13Z

- What I did
Extend timeout for waiting for UpdatePrepared MCN condition.

- How to verify it

Disruptive tests should run more consistently in SNO.

- Description for the changelog
NO-ISSUE: Extend timeout for waiting for UpdatePrepared MCN condition for SNO resiliency in disruptive test suite

Summary by CodeRabbit

Tests
- Increased the wait time for configuration transition validation, improving reliability for slower updates.
- Reformatted timeout and interval parameters for improved readability.

openshift-merge-bot · 2026-08-20T18:54:16Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci · 2026-08-20T18:54:19Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coderabbitai · 2026-08-20T18:54:35Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 09356c01-5bfe-4cf8-9c8f-2e97f9453992

📥 Commits

Reviewing files that changed from the base of the PR and between 6145d28 and b3294d4.

📒 Files selected for processing (1)

test/extended/machineconfignode.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The extended MachineConfigNode test reformats a wait helper signature and increases the UpdatePrepared=True detection timeout from one minute to two minutes.

Changes

MachineConfigNode condition wait

Layer / File(s)	Summary
UpdatePrepared wait timeout `test/extended/machineconfignode.go`	The wait helper parameters are split across lines without behavior changes. The `UpdatePrepared=True` timeout increases from one minute to two minutes.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to b3294

The change is limited to a localized test adjustment, with no identified correctness, security, availability, deployment, or rollback risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only helper formatting and a timeout literal; the diff adds no Ginkgo test title or dynamic test-name content.
Test Structure And Quality	✅ Passed	The PR only reformats a helper signature and changes UpdatePrepared wait from 1 to 2 minutes; PollUntilContextTimeout and diagnostic assertions remain intact, with no new setup or cleanup issue.
Microshift Test Compatibility	✅ Passed	The diff only reformats a helper signature and changes an existing wait from one to two minutes; it adds no Ginkgo test or new MicroShift-incompatible API use.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The diff only reformats a helper signature and changes a wait timeout; it adds no Ginkgo e2e test or multi-node/HA assumption.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff changes only test/extended/machineconfignode.go: formatting and a wait timeout. It adds no manifests, operators, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only function formatting and a timeout literal. The diff adds no stdout-writing API or process-level setup code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only timeout formatting and a wait duration in an existing helper; it adds no Ginkgo e2e test and introduces no IPv4 or external connectivity assumption.
No-Weak-Crypto	✅ Passed	The commit changes only Go formatting and a wait timeout from one to two minutes; it introduces no weak crypto or secret comparison code.
Container-Privileges	✅ Passed	The diff changes only Go formatting and a wait timeout; it adds no container/Kubernetes manifest or privileged setting such as hostPID, hostNetwork, SYS_ADMIN, or root execution.
No-Sensitive-Data-In-Logs	✅ Passed	The HEAD diff adds only function-signature formatting and changes a timeout from 1 to 2 minutes; logger calls are identical in HEAD and its parent, with no sensitive log additions.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: increasing the timeout for the UpdatePrepared MCN condition to improve SNO resiliency.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

isabella-janssen · 2026-08-20T18:55:52Z

/payload-job periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

isabella-janssen · 2026-08-20T18:55:57Z

/payload-job periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

openshift-ci · 2026-08-20T18:55:59Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c4cc6d80-9cc8-11f1-92fa-372627f4c028-0

isabella-janssen · 2026-08-20T18:55:59Z

/payload-job periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

isabella-janssen · 2026-08-20T18:56:02Z

/payload-job periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

isabella-janssen · 2026-08-20T18:56:04Z

/payload-job periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

openshift-ci · 2026-08-20T18:56:04Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c7c08030-9cc8-11f1-9df4-3580c52c9be2-0

openshift-ci · 2026-08-20T18:56:04Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c8e4dbf0-9cc8-11f1-8d04-f0617e4aa454-0

openshift-ci · 2026-08-20T18:56:07Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/caf93d00-9cc8-11f1-936d-eb673a5a13a5-0

openshift-ci · 2026-08-20T18:56:07Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cb8ffec0-9cc8-11f1-8e4a-a62de6a455bf-0

isabella-janssen · 2026-08-20T18:56:13Z

/payload-abort

openshift-ci · 2026-08-20T18:56:16Z

@isabella-janssen: aborted 5 active payload job(s) for pull request #6428

isabella-janssen · 2026-08-20T18:56:23Z

/payload-job periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

isabella-janssen · 2026-08-20T18:56:25Z

/payload-job periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

isabella-janssen · 2026-08-20T18:56:27Z

/payload-job periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

openshift-ci · 2026-08-20T18:56:27Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d743c0d0-9cc8-11f1-8b5a-847c541034b0-0

isabella-janssen · 2026-08-20T18:56:29Z

/payload-job periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

openshift-ci · 2026-08-20T18:56:30Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d882f790-9cc8-11f1-9795-e649a757aebf-0

isabella-janssen · 2026-08-20T18:56:31Z

/payload-job periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

openshift-ci · 2026-08-20T18:56:31Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d94a3f30-9cc8-11f1-857e-d5a520dadd2b-0

openshift-ci · 2026-08-20T18:56:34Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/db164ca0-9cc8-11f1-8bd8-e326632644cd-0

openshift-ci · 2026-08-20T18:56:35Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-1of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dbd4baa0-9cc8-11f1-811d-51eb0ed185a1-0

isabella-janssen · 2026-08-20T18:56:36Z

/payload-job periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-2of3

isabella-janssen · 2026-08-20T18:56:38Z

/payload-job periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-2of3

openshift-ci · 2026-08-20T18:56:48Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-2of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e399b650-9cc8-11f1-885a-44daf6b73577-0

isabella-janssen · 2026-08-20T18:56:49Z

/payload-job periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-3of3

isabella-janssen · 2026-08-20T18:56:51Z

/payload-job periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-3of3

openshift-ci · 2026-08-20T18:56:52Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e69c47f0-9cc8-11f1-8406-6c14972abf99-0

isabella-janssen · 2026-08-20T18:56:52Z

/payload-job periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-3of3

isabella-janssen · 2026-08-20T18:56:54Z

/payload-job periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-3of3

isabella-janssen · 2026-08-20T18:56:56Z

/payload-job periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-3of3

openshift-ci · 2026-08-20T18:56:56Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e77012b0-9cc8-11f1-8a70-f55161014bc2-0

openshift-ci · 2026-08-20T18:56:56Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e8cedf60-9cc8-11f1-8e9f-ed53df97b8c9-0

openshift-ci · 2026-08-20T18:56:58Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ea0cb690-9cc8-11f1-872f-db015021eb96-0

openshift-ci · 2026-08-20T18:57:00Z

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-machine-config-operator-release-5.1-periodics-e2e-aws-mco-single-node-disruptive-techpreview-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/eae53c40-9cc8-11f1-990a-51193db55be5-0

openshift-ci-robot · 2026-08-24T02:52:23Z

@isabella-janssen: This pull request explicitly references no jira issue.

Details

In response to this:

- What I did

- How to verify it

- Description for the changelog

Summary by CodeRabbit

Tests

Increased the wait time for configuration transition validation, improving reliability for slower updates.

Reformatted timeout and interval parameters for improved readability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen · 2026-08-24T02:54:30Z

/verified later @isabella-janssen

Post merge verification is fine for this because the goal is to improve SNO resiliency, which can only be validated through consistent job runs.

openshift-ci-robot · 2026-08-24T02:55:52Z

@isabella-janssen: This PR has been marked to be verified later by @isabella-janssen.

Details

In response to this:

/verified later @isabella-janssen

Post merge verification is fine for this because the goal is to improve SNO resiliency, which can only be validated through consistent job runs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen · 2026-08-24T10:50:59Z

/retest-required

openshift-ci · 2026-08-24T10:54:15Z

@isabella-janssen: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pablintino · 2026-08-24T11:00:25Z

/lgtm

openshift-merge-bot · 2026-08-24T11:01:09Z

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

The changed files don't match any pipeline_run_if_changed patterns
All files match pipeline_skip_if_only_changed patterns
No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.

openshift-ci · 2026-08-24T11:01:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [isabella-janssen,pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

extend prepared timeout

b3294d4

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2026

isabella-janssen changed the title ~~extend prepared timeout~~ NO-ISSUE: Extend timeout for waiting for UpdatePrepared MCN condition for SNO resiliency Aug 24, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 24, 2026

isabella-janssen marked this pull request as ready for review August 24, 2026 02:53

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2026

openshift-ci Bot requested review from pablintino and ptalgulk01 August 24, 2026 02:54

openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Aug 24, 2026

openshift-ci Bot assigned pablintino Aug 24, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2026

openshift-merge-bot Bot merged commit d14e296 into openshift:main Aug 24, 2026
9 checks passed

Uh oh!

Conversation

isabella-janssen commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Aug 20, 2026

Uh oh!

openshift-ci Bot commented Aug 20, 2026

Uh oh!

coderabbitai Bot commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

openshift-ci Bot commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

openshift-ci Bot commented Aug 20, 2026

Uh oh!

openshift-ci Bot commented Aug 20, 2026

Uh oh!

openshift-ci Bot commented Aug 20, 2026

Uh oh!

openshift-ci Bot commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

openshift-ci Bot commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

openshift-ci Bot commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

openshift-ci Bot commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

openshift-ci Bot commented Aug 20, 2026

Uh oh!

openshift-ci Bot commented Aug 20, 2026

Uh oh!

openshift-ci Bot commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

openshift-ci Bot commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

openshift-ci Bot commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

isabella-janssen commented Aug 20, 2026

Uh oh!

openshift-ci Bot commented Aug 20, 2026

Uh oh!

openshift-ci Bot commented Aug 20, 2026

isabella-janssen commented Aug 20, 2026 •

edited

Loading

coderabbitai Bot commented Aug 20, 2026 •

edited

Loading