Skip to content

NO-ISSUE: Extend timeout for waiting for UpdatePrepared MCN condition for SNO resiliency #6428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Aug 24, 2026
+3 −3
Merged

NO-ISSUE: Extend timeout for waiting for UpdatePrepared MCN condition for SNO resiliency #6428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/extended/machineconfignode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ func isTransientConnectionError(err error) bool {
// "Unknown," the function will also return true if the condition is "True," which ensures that we
// do not fail when an update progresses quickly through the intermediary "Unknown" phase.
func waitForMCNConditionStatus(machineConfigClient *machineconfigclient.Clientset, mcnName string, conditionType mcfgv1.StateProgress, status metav1.ConditionStatus,
timeout time.Duration, interval time.Duration, stopOnTransientError bool) (bool, error) {

timeout time.Duration, interval time.Duration, stopOnTransientError bool,
) (bool, error) {
conditionMet := false
var conditionErr error
var workerNodeMCN *mcfgv1.MachineConfigNode
Expand Down Expand Up @@ -243,7 +243,7 @@ func ValidateTransitionThroughConditions(oc *exutil.CLI, machineConfigClient *ma
o.Expect(conditionMet).To(o.BeTrue(), "Error, could not detect Updated=False.")

logger.Infof("Waiting for UpdatePrepared=True")
conditionMet, err = waitForMCNConditionStatus(machineConfigClient, updatingNodeName, mcfgv1.MachineConfigNodeUpdatePrepared, metav1.ConditionTrue, 1*time.Minute, 1*time.Second, false)
conditionMet, err = waitForMCNConditionStatus(machineConfigClient, updatingNodeName, mcfgv1.MachineConfigNodeUpdatePrepared, metav1.ConditionTrue, 2*time.Minute, 1*time.Second, false)
o.Expect(err).NotTo(o.HaveOccurred(), fmt.Sprintf("Error occurred while waiting for UpdatePrepared=True: %v", err))
o.Expect(conditionMet).To(o.BeTrue(), "Error, could not detect UpdatePrepared=True.")

Expand Down