[core] Deprecate Popover in favor of PopoverNext by ggdouglas · Pull Request #8006 · palantir/blueprint

ggdouglas · 2026-04-02T02:39:56Z

Summary

Marks the legacy Popover class component as deprecated, following the same pattern used for Overlay -> Overlay2. PopoverNext is the recommended replacement (see #7573).

Changes

Adds a @deprecated JSDoc tag and a @fileoverview frozen-code notice to popover.tsx. The re-export in components/index.ts gets the corresponding eslint-disable-next-line comment.

Shared types like PopoverProps, PopoverInteractionKind, and PopoverAnimation are not deprecated since PopoverNext also uses them.

changelog-app · 2026-04-02T02:40:03Z

changelog-app · 2026-04-02T02:41:00Z

✅ Successfully generated changelog entries for:

packages/core/changelog
packages/datetime/changelog
packages/select/changelog
packages/table/changelog

Need to regenerate?

Simply interact with the changelog bot comment again to regenerate these entries.

📋Changelog Preview

💡 Improvements

[core] Deprecate Popover in favor of PopoverNext (#8006)
[core] Deprecate Popover in favor of PopoverNext (#8006)
[core] Deprecate Popover in favor of PopoverNext (#8006)

⏸️ Deprecations

[core] Deprecate Popover in favor of PopoverNext (#8006)

Copilot

Pull request overview

Deprecates the legacy Popover component in favor of PopoverNext, while suppressing internal @typescript-eslint/no-deprecated warnings across the monorepo to keep existing usages building cleanly.

Changes:

Added @fileoverview frozen-code notice and @deprecated JSDoc to packages/core/src/components/popover/popover.tsx.
Added targeted/file-level ESLint disables for @typescript-eslint/no-deprecated around legacy Popover usages in source and test files.
Updated the core components re-export to suppress deprecation lint for Popover.

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
packages/table/src/headers/columnHeaderCell.tsx	Suppresses deprecation lint for a legacy `Popover` menu usage.
packages/table/src/cell/formats/truncatedFormat.tsx	Suppresses deprecation lint for truncated-cell `Popover` usage.
packages/select/src/components/suggest/suggest.tsx	Suppresses deprecation lint around `Popover` usage and defaultProps access.
packages/select/src/components/suggest/suggest.test.tsx	File-level disable for deprecated `Popover` references in tests.
packages/select/src/components/select/select.tsx	Suppresses deprecation lint for legacy `Popover` usage.
packages/select/src/components/select/select.test.tsx	File-level disable for deprecated `Popover` references in tests.
packages/select/src/components/multi-select/multiSelect.tsx	Suppresses deprecation lint for `Popover` ref typing and usage.
packages/select/src/components/multi-select/multiSelect.test.tsx	File-level disable for deprecated `Popover` references in tests.
packages/select/src/common/selectPopoverProps.ts	Suppresses deprecation lint for exported `popoverRef` type using legacy `Popover`.
packages/docs-app/src/components/navHeader.tsx	Suppresses deprecation lint for legacy `Popover` usage.
packages/demo-app/src/examples/PopoverExample.tsx	Suppresses deprecation lint for demo usage of legacy `Popover`.
packages/datetime/src/components/timezone-select/timezoneSelect.test.tsx	File-level disable for deprecated `Popover` references in tests.
packages/datetime/src/components/date-range-input/dateRangeInput.tsx	Suppresses deprecation lint for legacy `Popover` usage.
packages/datetime/src/components/date-range-input/dateRangeInput.test.tsx	File-level disable for deprecated `Popover` references in tests.
packages/datetime/src/components/date-input/dateInput.tsx	Suppresses deprecation lint for legacy `Popover` usage.
packages/datetime/src/components/date-input/dateInput.test.tsx	File-level disable for deprecated `Popover` references in tests.
packages/datetime/src/common/datetimePopoverProps.ts	Suppresses deprecation lint for exported `popoverRef` type using legacy `Popover`.
packages/core/src/components/tooltip/tooltip.tsx	Suppresses deprecation lint for internal `Popover` ref and render usage.
packages/core/src/components/popover/popover.tsx	Adds deprecation and frozen-code documentation to legacy `Popover`.
packages/core/src/components/popover/popover.test.tsx	File-level disable for deprecated `Popover` references in tests.
packages/core/src/components/menu/menuItem.tsx	Suppresses deprecation lint for legacy `Popover` submenu usage.
packages/core/src/components/menu/menuItem.test.tsx	File-level disable for deprecated `Popover` references in tests.
packages/core/src/components/index.ts	Suppresses deprecation lint for `Popover` re-export.
packages/core/src/components/context-menu/contextMenuPopover.tsx	Suppresses deprecation lint for legacy `Popover` usage.
packages/core/src/components/context-menu/contextMenu.test.tsx	File-level disable for deprecated `Popover` references in tests.
packages/core/src/components/breadcrumbs/breadcrumbs.tsx	Suppresses deprecation lint for legacy overflow `Popover` usage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-02T02:47:28Z

+            // eslint-disable-next-line @typescript-eslint/no-deprecated
            const timeout = this.props.popoverProps?.transitionDuration ?? Popover.defaultProps.transitionDuration;


Suggest now depends on a deprecated symbol (Popover.defaultProps.transitionDuration) for timing logic. To reduce coupling and make a future PopoverNext migration easier, prefer a non-deprecated source for the default (e.g., a shared constant exported from a non-deprecated module, or a local fallback literal matching the current default).

Suggested change

// eslint-disable-next-line @typescript-eslint/no-deprecated

const timeout = this.props.popoverProps?.transitionDuration ?? Popover.defaultProps.transitionDuration;

const timeout = this.props.popoverProps?.transitionDuration ?? 300;

Copilot · 2026-04-02T02:47:29Z

+    // eslint-disable-next-line @typescript-eslint/no-deprecated
    popoverRef?: React.RefObject<Popover<DefaultPopoverTargetHTMLProps>>;


This exported public type (SelectPopoverProps.popoverRef) still forces the legacy deprecated Popover class into the public API surface. Consider introducing a non-deprecated “popover handle”/interface type (or a union that can support both Popover and PopoverNext refs) so downstream consumers don’t need to reference a deprecated symbol to type their refs.

Suggested change

// eslint-disable-next-line @typescript-eslint/no-deprecated

popoverRef?: React.RefObject<Popover<DefaultPopoverTargetHTMLProps>>;

popoverRef?: React.RefObject<any>;

blueprint-previews · 2026-04-02T02:50:48Z

Deprecate Popover component in favor of PopoverNext

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

blueprint-previews · 2026-04-07T19:07:54Z

Inline Popover default to avoid deprecated class reference

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

blueprint-previews · 2026-05-19T15:49:47Z

Deprecate Popover component in favor of PopoverNext

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

blueprint-previews · 2026-05-19T16:25:20Z

Deprecate Popover component in favor of PopoverNext

Build artifact links for this commit: documentation | landing | table | demo | storybook

This is an automated comment from the deploy-preview CircleCI job.

ggdouglas · 2026-05-19T17:50:09Z

Replaced by #8124

ggdouglas added the Package: core label Apr 2, 2026

Copilot AI review requested due to automatic review settings April 2, 2026 02:39

Copilot AI reviewed Apr 2, 2026

View reviewed changes

ggdouglas mentioned this pull request Apr 2, 2026

[eslint-plugin] Flag Popover as deprecated in favor of PopoverNext #8007

Merged

ggdouglas force-pushed the gd/deprecate-popover branch from 96b0b03 to b838227 Compare April 7, 2026 18:55

ggdouglas added 8 commits May 19, 2026 11:29

Handle undefined input in popoverPropsToNextProps

31c7fff

Use PopoverNext internally

0a40844

Guard handlePopoverClose against undefined event in date components

488822a

Merge consumer modifiers with internal middleware in Tooltip/MenuItem

34f0d49

Extract unmountWrappers utility function

200f2e4

[select,datetime] Type popoverRef as RefObject<PopoverNextRef>

1bade28

Unskip and fix tooltip tests

4d966d9

Unskip contextMenu and contextMenuSingleton tests

a050bea

ggdouglas force-pushed the gd/deprecate-popover branch from b838227 to f039903 Compare May 19, 2026 15:36

ggdouglas changed the base branch from develop to gd/popover-next-internal-migration May 19, 2026 15:37

ggdouglas added the no changelog label May 19, 2026

ggdouglas added 2 commits May 19, 2026 12:12

Replace Popover with PopoverNext in docs and examples

3e75a68

Deprecate Popover component in favor of PopoverNext

f778906

ggdouglas force-pushed the gd/deprecate-popover branch from f039903 to f778906 Compare May 19, 2026 16:13

ggdouglas force-pushed the gd/popover-next-internal-migration branch from 89fa1fd to 3e75a68 Compare May 19, 2026 16:13

ggdouglas removed the no changelog label May 19, 2026

Base automatically changed from gd/popover-next-internal-migration to develop May 19, 2026 17:45

ggdouglas closed this May 19, 2026

ggdouglas deleted the gd/deprecate-popover branch May 19, 2026 17:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core] Deprecate Popover in favor of PopoverNext#8006

[core] Deprecate Popover in favor of PopoverNext#8006
ggdouglas wants to merge 10 commits into
developfrom
gd/deprecate-popover

ggdouglas commented Apr 2, 2026 •

edited

Loading

Uh oh!

changelog-app Bot commented Apr 2, 2026 •

edited by ggdouglas

Loading

Uh oh!

changelog-app Bot commented Apr 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blueprint-previews Bot commented Apr 2, 2026

Uh oh!

blueprint-previews Bot commented Apr 7, 2026

Uh oh!

blueprint-previews Bot commented May 19, 2026

Uh oh!

blueprint-previews Bot commented May 19, 2026

Uh oh!

ggdouglas commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		// eslint-disable-next-line @typescript-eslint/no-deprecated
		const timeout = this.props.popoverProps?.transitionDuration ?? Popover.defaultProps.transitionDuration;

		// eslint-disable-next-line @typescript-eslint/no-deprecated
		popoverRef?: React.RefObject<Popover<DefaultPopoverTargetHTMLProps>>;

	// eslint-disable-next-line @typescript-eslint/no-deprecated
	popoverRef?: React.RefObject<Popover<DefaultPopoverTargetHTMLProps>>;
	popoverRef?: React.RefObject<any>;

Conversation

ggdouglas commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Uh oh!

changelog-app Bot commented Apr 2, 2026 • edited by ggdouglas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generate changelog in packages/core/changelog/@unreleased

Generate changelog in packages/datetime/changelog/@unreleased

Generate changelog in packages/select/changelog/@unreleased

Generate changelog in packages/table/changelog/@unreleased

Uh oh!

changelog-app Bot commented Apr 2, 2026

✅ Successfully generated changelog entries for:

Need to regenerate?

📋Changelog Preview

💡 Improvements

⏸️ Deprecations

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blueprint-previews Bot commented Apr 2, 2026

Deprecate Popover component in favor of PopoverNext

Uh oh!

blueprint-previews Bot commented Apr 7, 2026

Inline Popover default to avoid deprecated class reference

Uh oh!

blueprint-previews Bot commented May 19, 2026

Deprecate Popover component in favor of PopoverNext

Uh oh!

blueprint-previews Bot commented May 19, 2026

Deprecate Popover component in favor of PopoverNext

Uh oh!

ggdouglas commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ggdouglas commented Apr 2, 2026 •

edited

Loading

changelog-app Bot commented Apr 2, 2026 •

edited by ggdouglas

Loading

Generate changelog in `packages/core/changelog/@unreleased`

Generate changelog in `packages/datetime/changelog/@unreleased`

Generate changelog in `packages/select/changelog/@unreleased`

Generate changelog in `packages/table/changelog/@unreleased`