[core] Move MultistepDialog inline styles to CSS#8099
Open
dokson wants to merge 1 commit into
Open
Conversation
MultistepDialog applied min-width: 800px and padding-bottom: 0 via inline
style on the underlying Dialog, forcing consumers to use !important to
override. Move both defaults into _multistep-dialog.scss under a single
.bp6-multistep-dialog class so they can be overridden with normal CSS
specificity. The MULTISTEP_DIALOG class constant already existed but was
never applied; it is now added to the rendered Dialog className.
The user-provided style prop continues to pass through via {...otherProps}.
Fixes palantir#7710.
Generate changelog in
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7710.
MultistepDialogappliedmin-width: 800pxandpadding-bottom: 0via the underlying Dialog's inlinestyleattribute, forcing consumers to use!importantto override (as shown in the issue's screenshot).This moves both defaults into
_multistep-dialog.scssunder a single.bp6-multistep-dialogclass so they can be overridden with normal CSS specificity:The
Classes.MULTISTEP_DIALOG(bp6-multistep-dialog) class constant already existed but was never applied to the rendered element; it is now added to the Dialog className.The user-provided
styleprop continues to pass through via{...otherProps}, so<MultistepDialog style={{ minWidth: 600 }} />still works (inline beats class).Test plan
pnpm --filter @blueprintjs/core run compilepnpm --filter @blueprintjs/core run test:typeCheckpnpm --filter @blueprintjs/core run test:vitest:run— 1250 passednpx prettier --checkon changed files