Skip to content

[core] Move MultistepDialog inline styles to CSS #8099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dokson wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[core] Move MultistepDialog inline styles to CSS #8099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/core/src/components/dialog/_multistep-dialog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,16 @@
@import "../../common/variables";

$dialog-border-radius: $pt-border-radius !default;
$multistep-dialog-min-width: 800px !default;
$step-radius: $pt-border-radius !default;

// Defaults previously applied via inline styles. Moved to CSS so consumers can override
// without `!important`. Specificity is a single class, matching Dialog's own rules.
.#{$ns}-multistep-dialog {
min-width: $multistep-dialog-min-width;
padding-bottom: 0;
}

.#{$ns}-multistep-dialog-panels {
display: flex;

Expand Down
10 changes: 1 addition & 9 deletions packages/core/src/components/dialog/multistepDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,6 @@ interface MultistepDialogState {
selectedIndex: number;
}

const PADDING_BOTTOM = 0;

const MIN_WIDTH = 800;

/**
* Multi-step dialog component.
*
Expand Down Expand Up @@ -130,13 +126,13 @@ export class MultistepDialog extends AbstractPureComponent<MultistepDialogProps,
isCloseButtonShown={isCloseButtonShown}
{...otherProps}
className={classNames(
Classes.MULTISTEP_DIALOG,
{
[Classes.MULTISTEP_DIALOG_NAV_RIGHT]: navigationPosition === "right",
[Classes.MULTISTEP_DIALOG_NAV_TOP]: navigationPosition === "top",
},
className,
)}
style={this.getDialogStyle()}
>
<div className={Classes.MULTISTEP_DIALOG_PANELS}>
{this.renderLeftPanel()}
Expand All @@ -156,10 +152,6 @@ export class MultistepDialog extends AbstractPureComponent<MultistepDialogProps,
}
}

private getDialogStyle() {
return { minWidth: MIN_WIDTH, paddingBottom: PADDING_BOTTOM, ...this.props.style };
}

private renderLeftPanel() {
return (
<div className={Classes.MULTISTEP_DIALOG_LEFT_PANEL} role="tablist" aria-label="steps">
Expand Down