Croparea update - #67
Draft
FelicitasBeier wants to merge 24 commits into
Draft
Conversation
Merge branch 'master' into cropareaUpdate # Conflicts: # .buildlibrary # CITATION.cff # DESCRIPTION # README.md
Merge branch 'master' into cropareaUpdate # Conflicts: # .buildlibrary # CITATION.cff # DESCRIPTION # README.md
…rt switchting to 2020 yet
Merge branch 'master' into cropareaUpdate # Conflicts: # .buildlibrary # CITATION.cff # DESCRIPTION # README.md
…LARMAGPIE and used in GAMS code
This was referenced Aug 6, 2026
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Aug 6, 2026
The aggregationlevel == "iso" branch called toolAggregate() as a bare
expression and discarded the result, leaving out undefined. Since "iso" is
the default, calcOutput("AreaActuallyIrrigated") failed with
"object 'out' not found"; only the else branch ever returned.
Assign the aggregation to out, matching the else branch and the documented
return value.
Addresses review finding m4.
Merge branch 'master' into cropareaUpdate # Conflicts: # .buildlibrary # CITATION.cff # DESCRIPTION # README.md
Changes values, not just tidying: reported irrigated area goes down.
Irrigated fallow area was being summed into the irrigated total. Because
mrlandcore calcCroparea imputes fallow's irrigation split from each cell's
overall irrigation share, every cell with fallow land and any irrigated
cropland contributed, so the reduction is broad rather than rare. Per the
author's decision, AreaActuallyIrrigated should not include fallow.
Also drops round = 6, which perturbs the last decimals on top of that.
Unquantified - madrat was not run. The check that would settle it is to
compare dimSums(calcOutput("AreaActuallyIrrigated", aggregate = FALSE),
dim = 1) per year, before and after.
Addresses review finding m3.
Contributor
Author
|
All issues raised by AI reviewer have been addressed. I will mark the comment as "resolved" to not confuse human reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Croparea update to LandInG and replacing LUH3 calls with LandUseInitialisation.