Croparea update - #41
Draft
FelicitasBeier wants to merge 19 commits into
Draft
Conversation
Merge branch 'master' into cropareaUpdate # Conflicts: # .buildlibrary # CITATION.cff # DESCRIPTION # README.md
corresponding PastrTauHist
…all no longer be used
This was referenced Aug 6, 2026
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Aug 6, 2026
lintr object_name_linter requires camelCase. Local variable in one function, both occurrences renamed; grep confirms none left and the name is not used across file boundaries. Addresses review finding m9.
The FAOValidYields branch was renamed to MadratLandInGFAOLUH, but three strings still said FAO: - the roxygen @PARAM, which had never documented this branch at all and then briefly named the intermediate spelling - sourceName, which line 76 stamps into the output as the model name, so the published Tau series still claimed FAO provenance - the description, which said "based on FAO yield trends" although the yields are FAO production over LandInG croparea Also passes the datasource explicitly to calcValidYield and builds the subscript from the same string, instead of hardcoding the model name in a subscript that silently depended on a default in another file. That coupling is what broke when the datasource was renamed.
Contributor
Author
|
All issues raised by AI reviewer have been addressed. I will mark the comment as "resolved" to not confuse human reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated croparea to LandInG data