fix: Historically a value of maxResults resulted in fetching everything - by explicitly checking that maxResults is 0 or False this behaviour was changed. - #2446
Open
dbaxa wants to merge 1 commit into
Conversation
…by explicitly checking that maxResults is 0 or False this behaviour was changed. Yes type checking should mostly prevent passing a None value for maxResults but we can simplify the check - any false like value for maxResults should result in fetching everything. Signed-off-by: David Black <dblack@atlassian.com>
|
Label error. Requires at least 1 of: breaking, chore, feat, fix. Found: . Follow https://www.conventionalcommits.org to get auto-labeling to work correctly. |
dbaxa
changed the title
dbaxa
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Historically a value of maxResults resulted in fetching everything - y explicitly checking that maxResults is 0 or False this behaviour was changed by explicitly checking that maxResults is 0 or False this behaviour was changed.
Yes type checking should mostly prevent passing a None value for maxResults but we can simplify the check - any false like value for maxResults should result in fetching everything.