Skip to content

fix: Historically a value of maxResults resulted in fetching everything - by explicitly checking that maxResults is 0 or False this behaviour was changed. #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dbaxa wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: Historically a value of maxResults resulted in fetching everything - by explicitly checking that maxResults is 0 or False this behaviour was changed. #2446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jira/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,7 @@ def _fetch_pages_searchToken(
ResultList: List of fetched items.
"""
DEFAULT_BATCH = 100 # Max batch size per request
fetch_all = maxResults in (0, False) # If False/0, fetch everything
fetch_all = not maxResults # If False/0/None, fetch everything

page_params = (params or {}).copy() # Ensure params isn't modified
page_params["maxResults"] = DEFAULT_BATCH if fetch_all else maxResults
Expand Down
Loading