fix: accept FastMCP HTTP factory kwargs#5694
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
size: S
2 tasks
|
@DouweM deepest apologies for the tag I'm aware of how incredibly busy you are. This small bug that unlocks quite a lot of features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MCPToolset(url, http_client=...)adapts the suppliedhttpx.AsyncClientinto FastMCP'shttpx_client_factoryhook. FastMCP's HTTP transports can call that factory with extra runtime kwargs such asfollow_redirects, so the adapter needs to accept and ignore them while still returning the caller-owned client.This keeps the existing URL/SSE behavior and only makes the factory tolerant of the extra transport kwargs.
Fixes #5688.
To verify
python -m pytest tests/test_mcp_toolset.py::TestMCPToolsetConstruction -q -p no:cacheprovider --basetemp .tmp/pytest-5688-construction2ruff format --check pydantic_ai_slim/pydantic_ai/mcp.py tests/test_mcp_toolset.pyruff check pydantic_ai_slim/pydantic_ai/mcp.py tests/test_mcp_toolset.pypyright pydantic_ai_slim/pydantic_ai/mcp.pypython -m py_compile pydantic_ai_slim/pydantic_ai/mcp.py tests/test_mcp_toolset.pygit diff --check