Skip to content

fix: accept FastMCP HTTP factory kwargs #5694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
he-yufeng wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

fix: accept FastMCP HTTP factory kwargs #5694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pydantic_ai_slim/pydantic_ai/mcp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2771,6 +2771,7 @@ def factory(
headers: dict[str, str] | None = None,
timeout: httpx.Timeout | None = None,
auth: httpx.Auth | None = None,
**_kwargs: Any,
) -> httpx.AsyncClient:
return http_client

Expand Down
4 changes: 4 additions & 0 deletions tests/test_mcp_toolset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,17 @@ def test_http_client_kwarg_uses_factory(self):
assert isinstance(toolset.client.transport, StreamableHttpTransport)
assert toolset.client.transport.httpx_client_factory is not None
assert toolset.client.transport.httpx_client_factory() is client
factory: Any = toolset.client.transport.httpx_client_factory
assert factory(follow_redirects=True) is client

def test_sse_url_with_http_client_uses_factory(self):
client = httpx.AsyncClient()
toolset = MCPToolset('https://example.com/sse', http_client=client)
assert isinstance(toolset.client.transport, SSETransport)
assert toolset.client.transport.httpx_client_factory is not None
assert toolset.client.transport.httpx_client_factory() is client
factory: Any = toolset.client.transport.httpx_client_factory
assert factory(follow_redirects=True) is client

def test_http_kwargs_with_non_url_input_raises(self):
"""HTTP-only kwargs (headers/auth/verify/http_client) must error out when the connection
Expand Down
Loading