Skip to content

Channels last: teach the data-movement passes both permute dialects - #22003

Open
rascani wants to merge 2 commits into
mainfrom
gh/rascani/15/head
Open

Channels last: teach the data-movement passes both permute dialects#22003
rascani wants to merge 2 commits into
mainfrom
gh/rascani/15/head

Conversation

@rascani

@rascani rascani commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Collect the aten and channels_last permute targets into one shared set and
thread it through the transforms that match, fuse, or assert on a permute.
Before this the passes matched aten.permute_copy by identity, so a
channels_last.permute_copy pair inserted by the layout replacement was
invisible to every canceller in the tree and survived untouched.

No pass gains a new capability; each simply stops ignoring half of the
operators it was written to handle. Inert for callers that never produce the
dialect, which today is all of them.

91 pre-existing permute and channels-last tests, plus a case pinning that an
inverse layout-copy pair around an elementwise operator now cancels.

Authored with Codex.

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22003

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 6 Unrelated Failures

As of commit 7785cf3 with merge base 8b93850 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant