Avoid allocating source lines when counting - #860
Closed
OskarEichler wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Count source lines without allocating an array and one string per line.
ASCII-compatible strings use a byte-count fast path. Non-ASCII-compatible encodings retain
each_linesemantics, preserving UTF-16/UTF-32 behavior.Evidence
For 100,000-line UTF-8 source, measured allocations fall from 100,002 to 1. Alternating local samples on Ruby 4.0.6 and 3.2.11 were approximately 12–16 times faster. This is a focused microbenchmark, not an application-throughput claim.
Verification
Compatibility
Returned data and source-map line-count semantics are unchanged. No dependency/version change. Existing tests were not edited under the consumer repository’s no-test-edit policy; focused evidence ran externally. Prepared with AI assistance.