Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
**Master**

- Count default source-map lines without allocating every source line. [Oskar Eichler](https://github.com/OskarEichler)

Get upgrade notes from Sprockets 3.x to 4.x at https://github.com/rails/sprockets/blob/master/UPGRADING.md

# 4.4.1
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ If you want to work on Sprockets or better understand how it works read [How Spr

## Behavior Overview

Default source-map line counting avoids retaining an array of every source line.

You can interact with Sprockets primarily through directives and file extensions. This section covers how to use each of these things, and the defaults that ship with Sprockets.

Since you are likely using Sprockets through another framework (such as the [Rails asset pipeline](http://guides.rubyonrails.org/asset_pipeline.html)), there will be configuration options you can toggle that will change behavior such as what directories or files get compiled. For that documentation you should see your framework's documentation.
Expand Down
10 changes: 8 additions & 2 deletions lib/sprockets/preprocessors/default_source_map.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,17 @@ module Preprocessors
# available.
class DefaultSourceMap
def call(input)
result = { data: input[:data] }
data = input[:data]
result = { data: data }
map = input[:metadata][:map]
filename = input[:filename]
load_path = input[:load_path]
lines = input[:data].lines.length
if data.encoding.ascii_compatible?
lines = data.b.count("\n")
lines += 1 unless data.empty? || data.end_with?("\n")
else
lines = data.each_line.count
end
basename = File.basename(filename)
mime_exts = input[:environment].config[:mime_exts]
pipeline_exts = input[:environment].config[:pipeline_exts]
Expand Down