Add workaround for subpixel rounding - #13
Open
hrjakobsen wants to merge 1 commit into
Open
Conversation
Contributor
|
weird. is this issue only present on Firefox? im not sure I noticed it |
Contributor
Author
I think so, yeah. My colleague didn't notice it happening on Safari at least. |
Contributor
|
hmm which OS are you using? I'm on Firefox as well on MacOS and not seeing it |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is a workaround, and very much a request-for-comments if you can come up with a better idea
After merging #12 yesterday, I've noticed that the Firefox subpixel rounding removes the marker at some font sizes / marker width levels.
What changed
I think it happens since
1chis a fractional value, hence the browser will have to do some rounding in the repeating pattern. What I cannot answer, however, is why this rounding sacrifices the 1px marker rather than the heap of transparent content right next to it.The solution to add a little bit of "padding" to the marker is not great, but it's the best I could come up with that seemed to fix in all of my test cases.
Sorry for not catching this in yesterdays PR.
Before:

After:
