Skip to content

Add workaround for subpixel rounding #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hrjakobsen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add workaround for subpixel rounding #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ const MARKER_COLOR_DARK = '#2B3245';
const MARKER_COLOR_ACTIVE_LIGHT = '#E4E5E6';
const MARKER_COLOR_ACTIVE_DARK = '#3C445C';

/** Thickness of indent markers. Probably should be integer pixel values. */
const MARKER_THICKNESS = '1px';
/** Thickness of indent markers */
const MARKER_THICKNESS = 1;

const indentTheme = EditorView.baseTheme({
'&light': {
Expand Down Expand Up @@ -60,8 +60,9 @@ const indentTheme = EditorView.baseTheme({
});

function createGradient(markerCssProperty: string, indentWidth: number, startOffset: number, columns: number) {
const gradient = `repeating-linear-gradient(to right, var(${markerCssProperty}) 0 ${MARKER_THICKNESS}, transparent ${MARKER_THICKNESS} ${indentWidth}ch)`
// Subtract one pixel from the background width to get rid of artifacts of pixel rounding
// the .2px offset to the MARKER_THICKNESS is to make sure that the marker is not removed by subpixel rounding
const gradient = `repeating-linear-gradient(to right, var(${markerCssProperty}) 0 ${MARKER_THICKNESS}px, transparent ${MARKER_THICKNESS + .2}px ${indentWidth}ch)`
// Subtract one pixel from the background width to get rid of artifacts of pixel rounding at the end of the gradient
return `${gradient} ${startOffset * indentWidth}.5ch/calc(${indentWidth * columns}ch - 1px) no-repeat`
}

Expand Down