Fix shell scripts checked out with CRLF on Windows - #451
Open
Adarsh04Arun wants to merge 1 commit into
Open
Conversation
Adarsh04Arun
requested review from
a team,
EXBreder,
ayubun,
haileyok and
vinaysrao1
as code owners
August 11, 2026 10:00
Contributor
📝 WalkthroughWalkthroughThe PR adds ChangesLine Ending Attributes
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Windows with
core.autocrlf=true(the Git for Windows default),*.shfilesare checked out with CRLF line endings. The shebang becomes
#!/bin/bash\r, andevery container that execs one fails with a misleading error:
This breaks the stock
docker compose uppath. Affected scripts includeentrypoint.sh,druid/specs/submit-specs.shandinit-minio-bucket.sh.The project already has an LF policy —
.pre-commit-config.yamlrunsmixed-line-ending --fix=lf— but it is only enforced at commit time.Nothing enforces LF at checkout time, which is where autocrlf breaks it.
This PR closes that half of the gap.
Why no
.shfiles are in this diffThe repository already stores LF. Verified with:
Only
\nappears — no\r. The CRLF is introduced purely on checkout, so.gitattributesalone is the complete fix and no file contents change.Verification
Before, on Windows:
After, on a fresh clone with this change:
Summary by CodeRabbit