Skip to content

Fix shell scripts checked out with CRLF on Windows #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Adarsh04Arun wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

Fix shell scripts checked out with CRLF on Windows #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Shell scripts must keep LF endings even when checked out on Windows.
#
# With core.autocrlf=true these get CRLF on checkout, which turns the shebang
# into `#!/bin/bash\r`. Linux containers then fail to exec them with the very
# unhelpful "no such file or directory" -- entrypoint.sh, the Druid spec
# submitter and the MinIO bucket init all break this way.
*.sh text eol=lf

# Same reasoning: these are executed inside containers.
Dockerfile text eol=lf
Dockerfile.* text eol=lf
*.dockerfile text eol=lf