feat: add Static KMS backend support to SSE/KMS configuration page - #179
Merged
Conversation
- Add 'Static' variant to KmsBackendType and KmsConfigPayload union - Add KmsStaticConfigPayload interface with secret_key field - Add key_id to KmsBackendSummary for backend status deserialization - Wire static backend in normalizeBackendType, buildFormStateFromStatus, buildConfigPayload - Render secret key password input and backend selector for static - Mark form read-only and disable Create/Delete key buttons when static is configured - Add 5 i18n keys for static KMS UI strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds full Console-side support for the
StaticKMS backend introduced in rustfs/rustfs#5222.Changes
types/kms.ts
"Static"toKmsBackendTypeunionkey_idtoKmsBackendSummaryKmsStaticConfigPayloadinterface withsecret_keyfieldKmsConfigPayloadunionapp/(dashboard)/sse/page.tsx
"static"backend through form state, normalization, deserialization, and payload builderstaticKmsReadOnly)canSetCreatedKeyAsDefaulti18n/locales/en-US.json
Verification
pnpm tsc --noEmit— no new errorspnpm lint— passedpnpm build— compiled successfully