fix: handle readonly bucket states safely - #188
Merged
Conversation
cxymds
marked this pull request as ready for review
July 28, 2026 09:52
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fix readonly bucket browsing so permission-limited S3 responses are represented accurately instead of redirecting users or inventing trusted state.
HeadBucketreturns 403; only redirect for a definitive missing bucket response.-whenGetBucketPolicyStatuscannot be read instead of incorrectly labeling the bucket private.GetBucketVersioningfail-closed for deletion safety without showing the genericFailed to get databanner.The root cause was that independent permission failures were being collapsed into unrelated states: 403 from
HeadBuckettriggered navigation, policy-status failure becamefalse, and object-list failure became an empty result.Type of Change
Testing
373 tests pass. TypeScript, ESLint, changed-file Prettier, lockfile sync, and diff checks pass.
Checklist
Related Issues
None.
Screenshots (if applicable)
Not included; the error states require permission-specific S3 responses.
Additional Notes
The full-repository
pnpm prettier --check .currently reports a pre-existing formatting issue inapp/(dashboard)/sse/page.tsx. That file is not changed by this PR; all files changed here pass Prettier.