Skip to content

use numba progress in threadpool#1220

Open
selmanozleyen wants to merge 4 commits into
scverse:mainfrom
selmanozleyen:chore/numba-progressbar
Open

use numba progress in threadpool#1220
selmanozleyen wants to merge 4 commits into
scverse:mainfrom
selmanozleyen:chore/numba-progressbar

Conversation

@selmanozleyen

Copy link
Copy Markdown
Member

Using numba-progress for the default case. In case of custom progress bar handling custom logic can be used. But that case can be explored in future PR's

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.52%. Comparing base (e36a6f8) to head (69a88ba).

Files with missing lines Patch % Lines
src/squidpy/_utils.py 78.57% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1220      +/-   ##
==========================================
- Coverage   76.54%   76.52%   -0.02%     
==========================================
  Files          63       63              
  Lines        9072     9088      +16     
  Branches     1523     1528       +5     
==========================================
+ Hits         6944     6955      +11     
- Misses       1542     1545       +3     
- Partials      586      588       +2     
Files with missing lines Coverage Δ
src/squidpy/_utils.py 62.16% <78.57%> (+0.51%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@selmanozleyen selmanozleyen changed the title use numba progress for in threadpool use numba progress in threadpool Jun 19, 2026
Comment thread src/squidpy/_utils.py
from tqdm.auto import tqdm

if TYPE_CHECKING:
from contextlib import AbstractContextManager

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to annotate the return type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants