Skip to content

feat: Add support for managing a team. - #88

Merged
acch merged 1 commit into
svalabs:mainfrom
kadaster:feat/teams
Feb 20, 2026
Merged

feat: Add support for managing a team.#88
acch merged 1 commit into
svalabs:mainfrom
kadaster:feat/teams

Conversation

@kad-hollac1

@kad-hollac1 kad-hollac1 commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@kad-hollac1
kad-hollac1 requested a review from acch as a code owner January 15, 2026 19:55
@kad-hollac1
kad-hollac1 force-pushed the feat/teams branch 3 times, most recently from 0529aed to 6763278 Compare January 16, 2026 10:33
@acch

acch commented Jan 24, 2026

Copy link
Copy Markdown
Member

Hi @kad-hollac1, thanks for opening this PR! Can you describe the specific scenario you're addressing with this change?

Also, looks like there's linter errors. Please ensure that the code builds & lints successfully, and that acceptance tests pass. Once that's done I'm happy to review your proposed changes.

@kad-hollac1

kad-hollac1 commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

Sure! In our organisation we're not managing the teams by hand and we've recently moved from Gitea to Forgejo. We want to move our provisioning from the Gitea TF provider to this one. For that we are still missing a few features we need and one of those is managing teams.

As for the linter errors: I'll fix them, I've setup golangci-lint locally now as well. :)

I'll wait for #86 with the acctests.

acch
acch requested changes Jan 30, 2026
View reviewed changes
Comment thread internal/provider/team_resource.go Outdated
Comment thread internal/provider/team_resource.go
Comment thread internal/provider/team_resource.go Outdated
Comment thread internal/provider/team_resource.go Outdated
@acch acch added enhancement New feature or request go Pull requests that update Go code labels Jan 30, 2026
@kad-hollac1
kad-hollac1 force-pushed the feat/teams branch 20 times, most recently from 0ebabd4 to 4080740 Compare February 4, 2026 05:25
@kad-hollac1
kad-hollac1 force-pushed the feat/teams branch 14 times, most recently from 6b56afb to d3cd895 Compare February 5, 2026 12:01
@kad-hollac1
kad-hollac1 requested a review from acch February 5, 2026 12:04
kad-hollac1
kad-hollac1 commented Feb 5, 2026
View reviewed changes
Comment thread internal/provider/team_resource.go
@kad-hollac1 kad-hollac1 mentioned this pull request Feb 6, 2026
Merged
@acch acch added the waiting-response Waiting for response from one of the maintainer label Feb 20, 2026
@kad-hollac1

kad-hollac1 commented Feb 20, 2026

Copy link
Copy Markdown
Contributor Author

For my information, is the label waiting-response that you are awaiting my respons?

@github-actions github-actions Bot removed the waiting-response Waiting for response from one of the maintainer label Feb 20, 2026
acch
acch requested changes Feb 20, 2026
View reviewed changes

@acch acch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kad-hollac1, the code looks very well! I have a few minor remarks, but I think we're very close to merging this...

Thanks a million for your valuable contribution!

Comment thread internal/provider/team_resource.go
Comment thread internal/provider/team_data_source.go Outdated
Comment thread internal/provider/team_data_source.go Outdated
@kad-hollac1
kad-hollac1 requested a review from acch February 20, 2026 12:33
@acch

acch commented Feb 20, 2026

Copy link
Copy Markdown
Member

Thank you very much for this @kad-hollac1! Merging the PR now...

Shall we release a new version with the forgejo_team resource right away, or would you prefer finalizing #95 and then including both in a new release?

@acch
acch merged commit 274f49e into svalabs:main Feb 20, 2026
5 checks passed
@kad-hollac1

kad-hollac1 commented Feb 20, 2026

Copy link
Copy Markdown
Contributor Author

Thank your for the review! :)

Yes, either is fine. I will rebase #95 right away, but there may be changes requested so up to you. :)

@kad-hollac1
kad-hollac1 deleted the feat/teams branch February 20, 2026 14:41
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@acch acch Awaiting requested review from acch acch is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request go Pull requests that update Go code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kad-hollac1 @acch