feat: Add support for team memberships.

[kad-hollac1]

Fixes: #94.

[kad-hollac1]

Requires #88.

[acch]

Hi @kad-hollac1 - thank you very much for this PR!

I had made some changes to your previous contribution, in order to make the forgejo_team resource implementation more consistent with the established patterns in the other resources. Please check out 6af6ee0, specifically regarding error handling and wording of error messages. I know I'm picky, but I'd like to keep those as homogeneous as possible across all resources.

Also, your tests seem to be failing...

[kad-hollac1]

Thanks I've changed some, I hope it is good enough now, let me know otherwise. Sorry I pushed the ,,request review'' button too soon. ^^

[acch]

Thanks much for this @kad-hollac1! I do have three requests, though:

1. Let's call the resource and data source forgejo_team_member. This is more consistent with the other resources, such as forgejo_collaborator.

2. Let's reference users by their name instead of their ID. As users are frequently created outside of Terraform, referencing them by their name is more convenient. You can refer to the forgejo_collaborator schema for an example.

3. Could you please add usage examples for forgejo_team and forgejo_team_member to the examples/ folder? These are included in the documentation when markdown is rendered.

[kad-hollac1]

2. Let's reference users by their name instead of their ID. As users are frequently created outside of Terraform, referencing them by their name is more convenient. You can refer to the `forgejo_collaborator` schema for an example.

Funnily enough, we'll be using it mainly for bot-users that our developers create themselves. ;) I'd actually say we should still reference by ID, for consistency, and let practitioners use a data indirection to reference them by name (cf. c59f532).

[acch]

Thanks much for these changes @kad-hollac1, the code looks very well now!

However, the current convention is to reference organisations and repositories by their ID, and users by their name (for the reasons stated). In order to keep this consistent across the provider, we would either need to change all resources and data sources to reference users by ID (forgejo_collaborator, forgejo_gpg_key, forgejo_repository, forgejo_ssh_key), or change forgejo_team_member to reference users by their name...

[kad-hollac1]

Sorry, I totally missed that the convention for users is different than for other entities. It is your call. If you actually want the former, I can create a separate patch for using IDs in other resources. Else I'll update this to use usernames.

[acch]

Thanks @kad-hollac1. I'd prefer to go with the current convention and update this resource and data source to use the user's name. The other alternative would be a major breaking change, which I'd like to avoid...

Thanks much for your continued efforts!

[kad-hollac1]

Thanks for the feedback, @acch. I've updated this merge request to use usernames.

[acch]

Thanks much for this @kad-hollac1! The code looks great, merging it now...

[kad-hollac1]

Thanks for the review and merge! :)