Repository navigation
feat(tin): sort and filter a divider by what's printed on the cards, and a grid view (#193) - #203
Merged
Merged
Conversation
This was referenced Oct 4, 2026
treyes133
force-pushed
the
feat/card-detail-evolutions-and-dividers
branch
from
October 4, 2026 03:07
00dc5bb to
63bf2d5
Compare
…and a grid view (#193) "Right now my dividers are just the Pokémon sorted by type, because I cannot find a way to sort my Pokémon by type and that's essential to me." Type, stage, HP, weakness and rarity have been in the catalog all along (`card.types`, `card.hp`, `detail` since #147); the tin's lists only offered Newest / Highest value / A to Z, and no filters at all. Everything and every divider now offer, under View options: - Sort: + set order (release date, then printed number) oldest or newest first, rarest first, highest HP. Highest value now sorts by the figure the row prints, so a row that says "no data" sinks instead of sitting mid-list on an estimate it doesn't show. - Filter: type, stage (Trainer and Energy count as stages), weakness, rarity — each listing only values present in this list. A "Showing 12 of 240 · Psychic — Clear" line stays on screen while a filter is on, so a short list can't read as cards gone missing. Search ignores filters: "do I own this?" mustn't be answered no by a filter you forgot. - Select All ticks the filtered cards, so filter to Psychic → Select → Select All → Move to… files exactly those. That's the workflow the issue is asking for. - Show as grid (remembered): card art, ×N, value and change, long-press for the row actions. A ScrollView grid, not the List — a List row can't hold a grid of independent links — so Select switches back to rows to tick them. Sorting/filtering is pure (`TinSorting`, `TinFilter`) over a card lookup, tested without a view. Rarity order is a keyword ladder across 28 years of rarity names. The Cards / Dividers / Sealed segmenting of the tab waits for binders (#194), as planned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
treyes133
force-pushed
the
feat/tin-sort-filter
branch
from
October 4, 2026 03:09
b80ce20 to
828b646
Compare
treyes133
changed the base branch from
feat/card-detail-evolutions-and-dividers
to
staging
October 4, 2026 03:09
treyes133
added a commit
that referenced
this pull request
Oct 4, 2026
1.0.5 (build 45) was approved on 2026-08-21 and promoted to main as #189, which closes its train for new builds. 1.0.6 carries everything merged to staging since: the % change fix (#201), the card screen's evolution line and divider links (#202), sorting/filtering/grid for dividers (#203), collecting mode (#204), "File all in…" for the scan tray (#205), and the scanner haptic fix (#192). Not verified against appStoreVersions — this machine has no App Store Connect credentials. The note above MARKETING_VERSION says what to check before the first upload. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Part of #193: "Right now my dividers are just the Pokémon sorted by type, because I cannot find a way to sort my Pokémon by type and that's essential to me." Type, stage, HP, weakness and rarity have been in the catalog all along. The tin's lists offered Newest / Highest value / A to Z, and no filters.
Everything and every divider now offer, under View options:
Sorting and filtering are pure (
TinSorting,TinFilter) over a card lookup, so they're tested without a view. Rarity order is a keyword ladder across 28 years of rarity names.The Cards / Dividers / Sealed segmenting of the tab waits for binders (#194), as planned there.
Stack (3 of 5). staging ← #201 (% fix) ← #202 (card screen, #197) ← #203 (sort/filter/grid, #193) ← #204 (collecting mode, #198) ← #205 (file all, #199). Merge in order. Merged branches aren't auto-deleted here, so after merging the PR below this one, delete its branch and GitHub retargets this one. If you squash-merge, this branch needs a rebase onto
stagingfirst; ask and I'll do it.Checklist
TinListOptionsTests).env, keys, ordocs/contents committedstaging(feature work), notmaindirectly. Stacked: base is the PR below it until that merges.🤖 Generated with Claude Code