Repository navigation
feat: collecting mode — hide card values and price changes (#198) - #204
Merged
Merged
Conversation
This was referenced Oct 4, 2026
Merged
Closed
treyes133
force-pushed
the
feat/tin-sort-filter
branch
from
October 4, 2026 03:09
b80ce20 to
828b646
Compare
"Some people are just here for the love of the game. Let me turn off the card value views throughout the app so it can be just a collecting mode." Settings → App → Collecting mode. Scope (decided 2026-10-03): no values and no % changes anywhere you browse or file cards; tools you open to talk about money keep their numbers. Hidden: - The tin header becomes "312 cards in your tin" (no Portfolio link); divider trays, the divider/Everything plaque, its performance chart and "Change vs" picker, flip-through, the "Sold … for $X" caption, and the Highest value sort. - Every PriceLabel and DeltaBadge (rows, grids, search, set and Pokédex grids, Discover tiles, "In your tin"), via `\.hidesPrices`, so new uses inherit the rule. - Card screen: the price block, history, "Grade it?" and the paid line. Art, what the card is, your copies, population and marketplace links stay. - Scan tray and review totals, the add form's "Holo · $12" labels, sealed values, binder lens. - Discover's price-defined shelves (Easy adds, Worth a think, Someday, Cheapest in 6 months, Down this week), the "what would you spend?" prompt, and "Chase · $X" → "Chase". - The Movers tab and the Watching row: nothing but price movement. - The widget shows the card count, with no change or sparkline (`WidgetSnapshot.hidesPrices`, optional so snapshots already on disk still decode; republished when the toggle flips). Kept, explicitly via `.keepsPrices()`: the wishlist (a target means nothing without the market beside it), the For Trade list and trade sessions. Printed reports and trade sheets render outside the app's environment and are untouched, as is the catalog browser's price filter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
treyes133
force-pushed
the
feat/collecting-mode
branch
from
October 4, 2026 03:10
8eea23c to
6fe7131
Compare
treyes133
added a commit
that referenced
this pull request
Oct 4, 2026
1.0.5 (build 45) was approved on 2026-08-21 and promoted to main as #189, which closes its train for new builds. 1.0.6 carries everything merged to staging since: the % change fix (#201), the card screen's evolution line and divider links (#202), sorting/filtering/grid for dividers (#203), collecting mode (#204), "File all in…" for the scan tray (#205), and the scanner haptic fix (#192). Not verified against appStoreVersions — this machine has no App Store Connect credentials. The note above MARKETING_VERSION says what to check before the first upload. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #198: "Some people are just here for the love of the game. Let me turn off the card value views throughout the app so it can be just a collecting mode."
Settings → App → Collecting mode. The rule: no values and no % changes anywhere you browse or file cards. Tools you open to talk about money keep their numbers.
Hidden:
PriceLabelandDeltaBadge(rows, grids, search, set and Pokédex grids, Discover tiles, "In your tin"), via a new\.hidesPricesenvironment value, so future uses inherit the rule.WidgetSnapshot.hidesPricesis optional so snapshots already on disk still decode, and the snapshot is republished when the toggle flips.Kept, explicitly via
.keepsPrices(): the wishlist (a target price means nothing without the market beside it), the For Trade list and trade sessions. Printed reports and trade sheets render outside the app's environment and are untouched, as is the catalog browser's price filter (a tool you open on purpose).Stack (4 of 5). staging ← #201 (% fix) ← #202 (card screen, #197) ← #203 (sort/filter/grid, #193) ← #204 (collecting mode, #198) ← #205 (file all, #199). Merge in order. Merged branches aren't auto-deleted here, so after merging the PR below this one, delete its branch and GitHub retargets this one. If you squash-merge, this branch needs a rebase onto
stagingfirst; ask and I'll do it.Checklist
.env, keys, ordocs/contents committedstaging(feature work), notmaindirectly. Stacked: base is the PR below it until that merges.🤖 Generated with Claude Code