fix(web): make composer session mention pills ellipsize - #1678
Open
junmo-kim wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Findings
- None.
Summary
- Review mode: initial
- No issues found in the added or modified lines. Residual testing risk:
web/src/components/AssistantChat/RichComposerInput.test.tsx:108verifies Tailwind class placement under jsdom, but does not exercise actual ellipsis or baseline layout in a browser.
Testing
- Not run (automation)
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the rich composer, a long session mention pill is hard-clipped without any ellipsis:
The pill class uses
inline-flex ... truncate, buttext-overflow: ellipsisdoes not apply to a flex container itself (the text node becomes a flex item), sooverflow: hiddenjust cuts the text mid-glyph. Additionally, an inline-block with non-visible overflow aligns by its bottom margin edge, so naive fixes break vertical alignment.Fix
Keep the pill as an inline-flex atom but move truncation to an inner label span: the outer pill stays
align-baseline(its baseline remains the text baseline since it no longer clips), while the inner label carriesmin-w-0 truncatefor working ellipsis. Cap relaxed from 12rem to 16rem for readability with longer (e.g. CJK) titles:data-composer-*attributes, tooltip aria-label, and segment parsing/caret logic are unchanged.Testing
truncateand the pill keeps baseline alignment (RED before / GREEN after).bun run typecheckand fullbun run testpass.