Skip to content

fix(web): make composer session mention pills ellipsize #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
junmo-kim wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(web): make composer session mention pills ellipsize #1678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions web/src/components/AssistantChat/RichComposerInput.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,25 @@ function ProgrammaticEditHarness() {
)
}

function MentionHarness() {
const [value, setValue] = useState('')
const ref = useRef<RichComposerInputHandle>(null)

return (
<>
<button
type="button"
onClick={() =>
ref.current?.insertSessionMention({ id: 'sid-1', title: '아주 긴 데모 세션 이름 예시 말줄임표 필요' })
}
>
Insert mention
</button>
<RichComposerInput ref={ref} value={value} onValueChange={setValue} onMirrorChange={() => {}} />
</>
)
}

function LineBreakDeletionHarness() {
const [value, setValue] = useState('hello')

Expand All @@ -89,6 +108,22 @@ function LineBreakDeletionHarness() {
)
}

describe('RichComposerInput session mention pill', () => {
it('renders the mention pill with working text ellipsis clipping', () => {
render(<MentionHarness />)

fireEvent.click(screen.getByRole('button', { name: 'Insert mention' }))

const pill = screen.getByText('@아주 긴 데모 세션 이름 예시 말줄임표 필요')
// Ellipsis lives on the inner label; the pill itself centers it vertically.
expect(pill.className).toContain('truncate')
expect(pill.parentElement?.dataset.composerMention).toBe('session')
expect(pill.parentElement?.className).toContain('inline-flex')
expect(pill.parentElement?.className).toContain('align-baseline')
expect(pill.parentElement?.className).not.toContain('overflow-hidden')
})
})

describe('RichComposerInput responsive placeholder', () => {
it('calculates a smaller font that fits overflowing text', () => {
expect(fitSingleLineFontSize(160, 320)).toBeCloseTo(7.95)
Expand Down
10 changes: 8 additions & 2 deletions web/src/components/AssistantChat/RichComposerInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,14 @@ function createMentionSpan(
span.dataset.sessionTitle = title
span.dataset.composerMention = 'session'
span.className =
'mx-0.5 inline-flex max-w-[12rem] items-center truncate rounded-md bg-[var(--app-subtle-bg)] px-1.5 py-0.5 align-baseline text-[0.95em] font-medium text-[var(--app-link)]'
span.textContent = `@${title || id.slice(0, 8)}`
'mx-0.5 inline-flex max-w-[16rem] items-baseline rounded-md bg-[var(--app-subtle-bg)] px-1.5 py-0.5 align-baseline text-[0.95em] font-medium text-[var(--app-link)]'
const label = document.createElement('span')
label.textContent = `@${title || id.slice(0, 8)}`
// Truncation lives on the inner label so the pill's own baseline stays a
// text baseline (an overflow≠visible inline-block would align by its
// bottom edge instead).
label.className = 'min-w-0 truncate'
span.appendChild(label)
const tip = resolveTooltip?.(id, title)?.model
?? formatSessionMentionTooltip(null, title, id)
span.setAttribute('aria-label', tip.ariaLabel)
Expand Down
Loading