Skip to content
This repository was archived by the owner on Apr 12, 2026. It is now read-only.

Add support for aarch64 and x86 architectures in releases#230

Open
mrtnvgr wants to merge 5 commits into
valentjn:developfrom
mrtnvgr:more-arches
Open

Add support for aarch64 and x86 architectures in releases#230
mrtnvgr wants to merge 5 commits into
valentjn:developfrom
mrtnvgr:more-arches

Conversation

@mrtnvgr

@mrtnvgr mrtnvgr commented Mar 3, 2023

Copy link
Copy Markdown

This PR closes #229.

@qRoC

qRoC commented Mar 16, 2023

Copy link
Copy Markdown

arm64 -> aarch64

@mrtnvgr mrtnvgr changed the title Add support for arm64 and x86 architectures in releases Add support for aarch64 and x86 architectures in releases Mar 16, 2023
@mrtnvgr

mrtnvgr commented Mar 16, 2023

Copy link
Copy Markdown
Author

@qRoC Hi! Can I ask you a question? Why did you remove x86-32 on your fork? Should I remove it here too?

@qRoC

qRoC commented Mar 16, 2023

Copy link
Copy Markdown

Hello, just for test.
11.0.12+7 does not contain some builds, 11.0.18+10 does not work:

Error: Hash of java.rmi (473234ff9c6b66f15c4c94acc5549542f361dac6bbfd0b08656e41f82867ac6e) differs to expected hash (d625849d78bdbbf431092f79032f21ddf8e8c1dfc48c9ac63132d598931b527d) recorded in java.base

Now I'm analyzing the problem, and then I'll return x86-32 back

@qRoC

qRoC commented Mar 16, 2023

Copy link
Copy Markdown

https://github.com/qRoC/ltex-ls/releases/tag/nightly

@mrtnvgr

mrtnvgr commented Mar 16, 2023

Copy link
Copy Markdown
Author

https://github.com/qRoC/ltex-ls/releases/tag/nightly

Thank you for testing my PR!

@mrtnvgr

mrtnvgr commented Mar 17, 2023

Copy link
Copy Markdown
Author

@qRoC I looked though your commits. I will be really nice if you make a PR about java version bump. 🤗

@qRoC

qRoC commented Mar 17, 2023

Copy link
Copy Markdown

If the author shows up, I'll do it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add arm64 to binary archives

2 participants