Skip to content

[turbopack] standardize chunk entry names for webpack and postcss loaders#94256

Open
lukesandberg wants to merge 2 commits into
canaryfrom
postcss_conflicts
Open

[turbopack] standardize chunk entry names for webpack and postcss loaders#94256
lukesandberg wants to merge 2 commits into
canaryfrom
postcss_conflicts

Conversation

@lukesandberg
Copy link
Copy Markdown
Contributor

@lukesandberg lukesandberg commented May 30, 2026

What?

Use the chunk_path api for computing entrypoint filepath names for our node worker pool files. For postcss loaders ensure that the config filepath is part of the module ident of the transformer.

Why?

I was investigating a bug in reported in next 16.2.6 (https://vercel.slack.com/archives/C09GRCW5MQR/p1780088728756579) and noticed that the chunk entry path construction logic was unusual. It happens to be that #91338 fixed the reported bug (just not released yet). This migrates all entry construction to the standard form

Copy link
Copy Markdown
Contributor Author

lukesandberg commented May 30, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 30, 2026

Stats skipped

Commit: b157db5
View workflow run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 30, 2026

Failing test suites

Commit: b157db5 | About building and testing Next.js

pnpm test-dev test/e2e/app-dir/instant-navigation-testing-api/instant-navigation-testing-api.test.ts (job)

  • instant-navigation-testing-api > renders runtime-prefetched content instantly during navigation (DD)
Expand output

● instant-navigation-testing-api › renders runtime-prefetched content instantly during navigation

locator.waitFor: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('[data-testid="search-param-value"]') to be visible

  105 |         '[data-testid="search-param-value"]'
  106 |       )
> 107 |       await searchParamValue.waitFor({ state: 'visible' })
      |                              ^
  108 |       expect(await searchParamValue.textContent()).toContain(
  109 |         'myParam: testValue'
  110 |       )

  at waitFor (e2e/app-dir/instant-navigation-testing-api/instant-navigation-testing-api.test.ts:107:30)
  at instant (../packages/next-playwright/dist/index.js:50:16)
  at Object.<anonymous> (e2e/app-dir/instant-navigation-testing-api/instant-navigation-testing-api.test.ts:99:5)

@lukesandberg lukesandberg changed the title allocate chunk paths based on entry names [turbopack] Fix chunk entry names for webpack and postcss loaders May 30, 2026
@lukesandberg lukesandberg marked this pull request as ready for review May 30, 2026 06:43
@lukesandberg lukesandberg changed the title [turbopack] Fix chunk entry names for webpack and postcss loaders [turbopack] standardize chunk entry names for webpack and postcss loaders May 30, 2026
@lukesandberg lukesandberg requested review from a team and sokra May 30, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant