merge nodejs pools#94320
Draft
lukesandberg wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Tests PassedCommit: fff9f6b |
Contributor
Stats skippedCommit: fff9f6b |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| } | ||
|
|
||
| /// Emits the PostCSS config as a standalone Node.js bundle to disk and returns | ||
| /// its path **relative to the project root** (the worker's cwd). |
Contributor
There was a problem hiding this comment.
Suggested change
| /// its path **relative to the project root** (the worker's cwd). | |
| /// its **absolute disk path** (the bundle lives under the output root, which | |
| /// may be on a different filesystem than the project, so the worker is given a | |
| /// path it can import directly). |
Doc comment on emit_postcss_config_bundle wrongly says it returns a project-relative path when it actually returns an absolute disk path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.