feat: Add configuration for Corebreeze 382S Pedestal Fan (LPF-R382S-AEU)#525
Open
returnofthem wants to merge 1 commit into
Open
feat: Add configuration for Corebreeze 382S Pedestal Fan (LPF-R382S-AEU)#525returnofthem wants to merge 1 commit into
returnofthem wants to merge 1 commit into
Conversation
Adds support for the 382S (LPF-R382S-AEU) and updates the fan levels to reflect the 382S only has 5 speed settings.
returnofthem
changed the title
returnofthem
changed the title
Author
|
Apologies for the initial mistakes, I'm new to this |
returnofthem
changed the title
Owner
|
@returnofthem Thank you for the PR, did you confirm that all the current fan methods work for you as well? Or is your fan missing some features that are in the library? |
Author
|
Hey @webdjoe the basic fan functions (on/off and speed) work fine, the oscillation controls are missing though - maybe because this fan only oscillates horizontally, whereas the bigger one does both horizontal and vertical? I had a go at fixing that locally and realised I was out of my depth, and then the fan had to be sent back anyway due to a separate issue so I no longer have it to test with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the 382S (LPF-R382S-AEU) and updates the fan levels to reflect the 382S only has 5 speed settings.