Change executeTool() inputObject type from object to any - #251
Merged
domfarolino merged 4 commits intoSep 10, 2026
Conversation
Collaborator
Author
|
@domfarolino If that looks good to you, I'll merge https://chromium-review.googlesource.com/c/chromium/src/+/8250826 |
domfarolino
reviewed
Sep 4, 2026
domfarolino
reviewed
Sep 4, 2026
emecii
added a commit
to emecii/webmcp
that referenced
this pull request
Sep 6, 2026
Two normative defects in algorithms that were introduced or partially fixed by earlier changes. `imperative execute steps` reads "If |inputObject| [=Object type|is not an Object=] is false", which inverts the intended condition: an Object input fails and a JSON scalar passes. The trailing "is false" is a leftover; PR webmachinelearning#251 writes the same construct without it. `notify documents of a tool change` and `getTools()` read HTML's [=Document/inclusive descendant navigables=] off a traversable navigable. HTML defines that operation for a Document (data-dfn-for=Document) and its own callers route through the traversable's active document. This completes the fix started in webmachinelearning#244, which corrected the same line from "descendant navigables" to "inclusive descendant navigables" but left the receiver wrong. `perform an observation` already does this correctly.
Collaborator
Author
|
@domfarolino I've updated this PR based on the latest patchset uploaded in https://chromium-review.googlesource.com/c/chromium/src/+/8250826 |
domfarolino
approved these changes
Sep 10, 2026
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 10, 2026
This CL updates ModelContext.executeTool() to accept an optional `any inputObject` parameter instead of `DOMString inputArguments`, aligning with the latest WebMCP specification changes. The input object is validated and serialized to a JSON string in Blink before being passed over Mojo IPC to the target tool execution context. Any serialization errors (e.g. circular structures, non-serializable types, or toJSON returning undefined) reject the returned promise with a TypeError. Spec PRs: webmachinelearning/webmcp#246 webmachinelearning/webmcp#251 Bug: 489045948 Change-Id: I95cc00e20a84134cf5f289e689441587200555f0
beckysiegel
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 10, 2026
This CL updates ModelContext.executeTool() to accept an optional `any inputObject` parameter instead of `DOMString inputArguments`, aligning with the latest WebMCP specification changes. The input object is validated and serialized to a JSON string in Blink before being passed over Mojo IPC to the target tool execution context. Any serialization errors (e.g. circular structures, non-serializable types, or toJSON returning undefined) reject the returned promise with a TypeError. Spec PRs: webmachinelearning/webmcp#246 webmachinelearning/webmcp#251 Bug: 489045948 Change-Id: I95cc00e20a84134cf5f289e689441587200555f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8250826 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1695589}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 10, 2026
This CL updates ModelContext.executeTool() to accept an optional `any inputObject` parameter instead of `DOMString inputArguments`, aligning with the latest WebMCP specification changes. The input object is validated and serialized to a JSON string in Blink before being passed over Mojo IPC to the target tool execution context. Any serialization errors (e.g. circular structures, non-serializable types, or toJSON returning undefined) reject the returned promise with a TypeError. Spec PRs: webmachinelearning/webmcp#246 webmachinelearning/webmcp#251 Bug: 489045948 Change-Id: I95cc00e20a84134cf5f289e689441587200555f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8250826 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1695589}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 11, 2026
This CL updates ModelContext.executeTool() to accept an optional `any inputObject` parameter instead of `DOMString inputArguments`, aligning with the latest WebMCP specification changes. The input object is validated and serialized to a JSON string in Blink before being passed over Mojo IPC to the target tool execution context. Any serialization errors (e.g. circular structures, non-serializable types, or toJSON returning undefined) reject the returned promise with a TypeError. Spec PRs: webmachinelearning/webmcp#246 webmachinelearning/webmcp#251 Bug: 489045948 Change-Id: I95cc00e20a84134cf5f289e689441587200555f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8250826 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1695589}
Closed
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following Blink IDL bindings folks feedback in https://chromium-review.googlesource.com/c/chromium/src/+/8250826, we're changing
executeTool()inputObject type fromobjecttoanywith special handling after #246.Preview | Diff